From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 499CF8DA2
for <dev@dpdk.org>; Mon, 2 Nov 2015 03:11:29 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga102.fm.intel.com with ESMTP; 01 Nov 2015 18:11:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,232,1444719600"; d="scan'208";a="592229458"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2015 18:11:28 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Sun, 1 Nov 2015 18:11:27 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.194]) by
SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0248.002;
Mon, 2 Nov 2015 10:11:26 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration
Thread-Index: AQHRExmYX7z/Lhmd+0yA/9qxckzZxJ6H+o5Q
Date: Mon, 2 Nov 2015 02:11:25 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A923D11@SHSMSX104.ccr.corp.intel.com>
References: <1446098572-4409-1-git-send-email-helin.zhang@intel.com>
<1446174687-2407-1-git-send-email-helin.zhang@intel.com>
<1446174687-2407-2-git-send-email-helin.zhang@intel.com>
<1825895.jnZdLtN9L6@xps13>
In-Reply-To: <1825895.jnZdLtN9L6@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 02:11:29 -0000
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, October 30, 2015 9:47 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configura=
tion
>=20
> 2015-10-30 11:11, Helin Zhang:
> > v7 changes:
> > Modified RTE_ETH_INSET_SIZE_MAX from 128 to 1, to avoid ABI changes.
>=20
> Why it would avoid ABI changes?
> Have you passed the ABI checker?
Hi Thomas
The only structure modified is ' struct rte_eth_hash_filter_info ', where a=
new
element (struct rte_eth_input_set_conf input_set_conf) was added. But I kep=
t its
structure the same size as another one (struct rte_eth_hash_global_conf glo=
bal_conf)
already in that union, they are both in 12 bytes. That means nothing change=
d for
' struct rte_eth_hash_filter_info'.
In addition, macro of ' RTE_ETH_INSET_SIZE_MAX ' was added by me in this pa=
tch set,
and I modified its default value from 128 to 1 in the latest version, which=
does not affect
ABI, as it is a totally new macro.
A new element was added at the last of ' enum rte_eth_hash_filter_info_type=
', I don't
think it will affect ABI as well.
struct rte_eth_hash_filter_info {
enum rte_eth_hash_filter_info_type info_type; /**< Information type=
*/
/** Details of hash filter information */
union {
/** For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */
uint8_t enable;
/** Global configurations of hash filter */
struct rte_eth_hash_global_conf global_conf;
/** Global configurations of hash filter input set */
struct rte_eth_input_set_conf input_set_conf;
} info;
};
I did ABI check, but it seems that something wrong in running that check on=
all PMDs,
like below. While all other checks are quite well.
I am not sure if anybody else can run it successfully.
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
ERROR: the input dump d1 is invalid
preparation, please wait ...
Regards,
Helin