From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 518DB8E7E for ; Mon, 23 Nov 2015 06:58:06 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 22 Nov 2015 21:58:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,335,1444719600"; d="scan'208";a="605535215" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 22 Nov 2015 21:58:05 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 22 Nov 2015 21:58:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.223]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.83]) with mapi id 14.03.0248.002; Mon, 23 Nov 2015 13:58:03 +0800 From: "Zhang, Helin" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH] i40e: fix issue of reconfigure hash enable flags Thread-Index: AQHRJbDtlhfSbosUlUaeQJRTeVzfCp6olR6AgACGsQA= Date: Mon, 23 Nov 2015 05:58:02 +0000 Message-ID: References: <1448256970-2722-1-git-send-email-helin.zhang@intel.com> <9BB6961774997848B5B42BEC655768F8D3E2EB@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F8D3E2EB@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fix issue of reconfigure hash enable flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2015 05:58:06 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Monday, November 23, 2015 1:54 PM > To: Zhang, Helin; dev@dpdk.org > Cc: Pei, Yulong > Subject: RE: [PATCH] i40e: fix issue of reconfigure hash enable flags >=20 > > > > - if (!key || key_len !=3D ((I40E_PFQF_HKEY_MAX_INDEX + 1) * > > - sizeof(uint32_t))) > > + if (!key || key_len =3D=3D 0) { > > + PMD_DRV_LOG(DEBUG, "No key to be configured"); > > + return 0; > > + } else if (key && (key_len !=3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > > + sizeof(uint32_t))) { > No need to check key in else if, it shouldn't be NULL here. Yes, it should be removed. Thanks! Regards, Helin > > + PMD_DRV_LOG(ERR, "Invalid key length %u", key_len); > > return -EINVAL; > > + } >=20 > Thanks > Jingjing