From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4DAD48D36 for ; Tue, 26 Jan 2016 01:29:14 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 25 Jan 2016 16:29:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,347,1449561600"; d="scan'208";a="898227273" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 25 Jan 2016 16:29:12 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 25 Jan 2016 16:29:12 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 25 Jan 2016 16:29:12 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Tue, 26 Jan 2016 08:29:10 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag Thread-Index: AQHRO5im2QAtE9XepEi3eWFbo8a0Ip8HAWqAgAM07VCAAW6EAIABhOlg Date: Tue, 26 Jan 2016 00:29:10 +0000 Message-ID: References: <1450665486-8335-1-git-send-email-helin.zhang@intel.com> <3789056.EpDHogkSc1@xps13> <1884621.9QzzlocIgN@xps13> In-Reply-To: <1884621.9QzzlocIgN@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 00:29:14 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, January 25, 2016 5:17 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag >=20 > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-12-21 10:38, Helin Zhang: > > > > PCIe feature of 'Extended Tag' is important for 40G performance. > > > > It adds its enabling during each port initialization, to ensure > > > > the high performance. > > > > > > If it's so important, why the values are not documented? > > > Please start to fill a file doc/guides/nics/i40e.rst to explain how > > > the device works. Thanks > > > > It has already been mentioned in getting started guide for a long time. > > Are you suggesting to move into i40e specifically? Thanks! >=20 > Yes you're right. I had forgotten that: > http://dpdk.org/doc/guides-2.2/linux_gsg/enable_func.html#enabling- > extended-tag-and-setting-max-read-request-size >=20 > Yes, it would be better moved into an i40e doc. > And maybe max_read_request_size may be commented to give advices on > values. > Thanks OK. Good idea, and I will move that soon later. Thanks! Regards, Helin