From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DFA3E95CE for ; Tue, 2 Feb 2016 03:14:42 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 01 Feb 2016 18:14:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,383,1449561600"; d="scan'208";a="874616658" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2016 18:14:34 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 18:14:32 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 18:14:32 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id 14.03.0248.002; Tue, 2 Feb 2016 10:14:29 +0800 From: "Zhang, Helin" To: "Qiu, Michael" , "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [PATCH v2] ixgbe: Fix disable interrupt twice Thread-Index: AQHRWlokuxzst+DuYUqlXTIjOup9yZ8YCY1w Date: Tue, 2 Feb 2016 02:14:28 +0000 Message-ID: References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com> <1454047090-21274-1-git-send-email-michael.qiu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909034256DA@shsmsx102.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E6028622F28091@SHSMSX101.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909034266D1@shsmsx102.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E6028622F28A4D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F28A4D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 02:14:43 -0000 > -----Original Message----- > From: Qiu, Michael > Sent: Tuesday, February 2, 2016 10:07 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Zhang, Helin > Subject: Re: [PATCH v2] ixgbe: Fix disable interrupt twice >=20 > [+cc helin] >=20 > On 2/2/2016 9:03 AM, Lu, Wenzhuo wrote: > > Hi Michael, > > > >> -----Original Message----- > >> From: Qiu, Michael > >> Sent: Monday, February 1, 2016 4:05 PM > >> To: Lu, Wenzhuo; dev@dpdk.org > >> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming > >> Subject: Re: [PATCH v2] ixgbe: Fix disable interrupt twice > >> > >> On 1/29/2016 4:07 PM, Lu, Wenzhuo wrote: > >>> Hi Michael, > >>> > >>>> -----Original Message----- > >>>> From: Qiu, Michael > >>>> Sent: Friday, January 29, 2016 1:58 PM > >>>> To: dev@dpdk.org > >>>> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Lu, Wenzhuo; Qiu, > >>>> Michael > >>>> Subject: [PATCH v2] ixgbe: Fix disable interrupt twice > >>>> > >>>> Currently, ixgbe vf and pf will disable interrupt twice in stop > >>>> stage and uninit stage. It will cause an error: > >>>> > >>>> testpmd> quit > >>>> > >>>> Shutting down port 0... > >>>> Stopping ports... > >>>> Done > >>>> Closing ports... > >>>> EAL: Error disabling MSI-X interrupts for fd 26 > >>>> Done > >>>> > >>>> Becasue the interrupt already been disabled in stop stage. > >>>> Since it is enabled in init stage, better remove from stop stage. > >>> I'm afraid it's not a good idea to just remove the intr_disable from > dev_stop. > >>> I think dev_stop have the chance to be used independently with > >>> dev_unint. In > >> this scenario, we still need intr_disable, right? > >>> Maybe what we need is some check before we disable the intr:) > >> Yes, indeed we need some check in disable intr, but it need > >> additional fields in "struct rte_intr_handle", and it's much saft to > >> do so, but as I check i40e/fm10k code, only ixgbe disable it in dev_st= op(). > > I found fm10k doesn't enable intr in dev_start. So, I think it's OK. Bu= t i40e > enables intr in dev_start. > > To my opinion, it's more like i40e misses the intr_disable in dev_stop. >=20 > I don't think i40e miss it, because it not the right please to disable in= terrupt. > because all interrupts are enabled in init stage. >=20 > Actually, ixgbe enable the interrupt in init stage, but in dev_start, it = disable it > first and re-enable, so it just the same with doing nothing about interru= pt. >=20 > Just think below: >=20 > 1. start the port.(interrupt already enabled in init stage, disable --> > re-enable) > 2. stop the port.(disable interrupt) > 3. start port again(Try to disable, but failed, already disabled) >=20 > Would you think the code has issue? [Zhang, Helin] in ixgbe PMD, it can be seen that uninit() calls dev_close()= , which calls dev_stop(). So I think the disabling can be done only in dev_st= op(). All others can make use of dev_stop to disable the interrupt. Regards, Helin >=20 > Thanks, > Michael >=20 > > Maybe we can follow fm10k's style. > > > >> On other hand, if we remove it in dev_stop, any side effect? In ixgbe > >> start, it will always disable it first and then re-enable it, so it's = safe. > > I think you mean we can disable intr anyway even if it has been disable= d. >=20 > Actually, we couldn't, DPDK call VFIO ioctl to kernel to disable interrup= ts, and > if we try disable twice, it will return and error. > That's why I mean we need a flag to show the interrupts stats. If it alre= ady > disabled, we do not need call in to kernel. just return and give a warnin= g > message. >=20 > Thanks, > Michael >=20 > > Sounds more like why we don't > > need this patch :) > > > >> Thanks, > >> Michael > >