From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 56B2795D5 for ; Thu, 4 Feb 2016 01:50:26 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 03 Feb 2016 16:50:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,392,1449561600"; d="scan'208";a="908042761" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2016 16:50:25 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:50:25 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:50:24 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id 14.03.0248.002; Thu, 4 Feb 2016 08:50:23 +0800 From: "Zhang, Helin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure Thread-Index: AQHRPUN7xKh4F3StAka5onw3sDr1ip8aP/MAgAERKkA= Date: Thu, 4 Feb 2016 00:50:22 +0000 Message-ID: References: <1450848779-8183-1-git-send-email-helin.zhang@intel.com> <20160203163112.GA2528@bricha3-MOBL3> In-Reply-To: <20160203163112.GA2528@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE3MmViNzItYjg3Yy00OTIzLThjZjEtZWZlOGJiMzZkNDZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTmkyc3VFTmxCZUdnVlJRRjQyMHRGdHVNNmlWV3k5NEhvRnNiMmNLWElzOD0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 00:50:26 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, February 4, 2016 12:31 AM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initializatio= n failure >=20 > On Wed, Dec 23, 2015 at 01:32:59PM +0800, Helin Zhang wrote: > > Workaround for the issue of cannot processing adminq commands during > > initialization, when 2x40G or 4x10G is receiving packets in highest > > throughput. Register 0x002698a8 and 0x002698ac should be cleared at > > first, and restored with the default values at the end. No more > > details, as they are not exposed registers. > > > > Signed-off-by: Helin Zhang >=20 > Hi Helin, >=20 > can you please add an appropriately "fixes" line to the patch, since the = subject > explicitly calls it out as a bug-fix. Also, the words "the issue" in the = subject can > be removed as they don't add value. It would also be worthwhile referenci= ng > the adminq in the subject too, since that is the failure being reported. = How > about: >=20 > "i40e: fix adminq failure on port init" Oh, sorry, I forgot this patch. Firmware finally fixed it in FVL5, and we need to use new AQ commands for r= eading/writing some registers. So I will drop this patch. Thanks! Regards, Helin >=20 > Regards, > /Bruce