From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id F0A752BFF
for <dev@dpdk.org>; Tue, 23 Feb 2016 03:11:04 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga103.fm.intel.com with ESMTP; 22 Feb 2016 18:11:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,487,1449561600"; d="scan'208";a="751308777"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
by orsmga003.jf.intel.com with ESMTP; 22 Feb 2016 18:11:02 -0800
Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by
fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Mon, 22 Feb 2016 18:11:02 -0800
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Mon, 22 Feb 2016 18:11:01 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
shsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id 14.03.0248.002;
Tue, 23 Feb 2016 10:10:58 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
Thread-Index: AQHRWlo0NHPVdF3SZ0WWbFlBqTw49J85Cgng
Date: Tue, 23 Feb 2016 02:10:57 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9AE93C@SHSMSX104.ccr.corp.intel.com>
References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com>
<1454047090-21274-1-git-send-email-michael.qiu@intel.com>
In-Reply-To: <1454047090-21274-1-git-send-email-michael.qiu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2016 02:11:05 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Friday, January 29, 2016 1:58 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
>=20
> Currently, ixgbe vf and pf will disable interrupt twice in stop stage and=
uninit
> stage. It will cause an error:
>=20
> testpmd> quit
>=20
> Shutting down port 0...
> Stopping ports...
> Done
> Closing ports...
> EAL: Error disabling MSI-X interrupts for fd 26
> Done
>=20
> Becasue the interrupt already been disabled in stop stage.
> Since it is enabled in init stage, better remove from stop stage.
>=20
> Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF")
>=20
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> v2 --> v1:
> fix error in commit log word "interrupte"
>=20
> drivers/net/ixgbe/ixgbe_ethdev.c | 6 ------
> 1 file changed, 6 deletions(-)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 4c4c6df..a561f8d 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2192,9 +2192,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> /* disable interrupts */
> ixgbe_disable_intr(hw);
>=20
> - /* disable intr eventfd mapping */
> - rte_intr_disable(intr_handle);
> -
> /* reset the NIC */
> ixgbe_pf_reset_hw(hw);
> hw->adapter_stopped =3D 0;
> @@ -3898,9 +3895,6 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev)
>=20
> ixgbe_dev_clear_queues(dev);
>=20
> - /* disable intr eventfd mapping */
> - rte_intr_disable(intr_handle);
> -
> /* Clean datapath event and queue/vec mapping */
> rte_intr_efd_disable(intr_handle);
> if (intr_handle->intr_vec !=3D NULL) {
> --
> 1.9.3