From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1E71D12A8 for ; Wed, 24 Feb 2016 01:39:40 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 23 Feb 2016 16:39:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,492,1449561600"; d="scan'208";a="909838731" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2016 16:39:39 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 23 Feb 2016 16:39:39 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 23 Feb 2016 16:39:39 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Wed, 24 Feb 2016 08:39:37 +0800 From: "Zhang, Helin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag Thread-Index: AQHRbSWDdKSQWgYShUq67z4tNC4RlZ847gQAgAFuIiA= Date: Wed, 24 Feb 2016 00:39:36 +0000 Message-ID: References: <1450665486-8335-3-git-send-email-helin.zhang@intel.com> <1456113585-15259-1-git-send-email-helin.zhang@intel.com> <1456113585-15259-2-git-send-email-helin.zhang@intel.com> <20160223104446.GA15436@bricha3-MOBL3> In-Reply-To: <20160223104446.GA15436@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzZmYzJjMTktMGZlYS00YTYyLWExN2QtMWEwYzkwM2YzMGJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1M4Y0dTYmFnUFAzSk5wYTZ5Nkl1VktjRnZTdjNPOEE0Tzhjd0d3WGZRQT0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "zhe.tag@intel.com" Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 00:39:41 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 23, 2016 6:45 PM > To: Zhang, Helin > Cc: dev@dpdk.org; zhe.tag@intel.com > Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag >=20 > On Mon, Feb 22, 2016 at 11:59:43AM +0800, Helin Zhang wrote: > > PCIe feature of 'Extended Tag' is important for 40G performance. > > It adds its enabling during each port initialization, to ensure the > > high performance. > > > > Signed-off-by: Helin Zhang > > --- > > doc/guides/rel_notes/release_16_04.rst | 6 ++++ > > drivers/net/i40e/i40e_ethdev.c | 65 > ++++++++++++++++++++++++++++++++-- > > 2 files changed, 68 insertions(+), 3 deletions(-) > > > > v2: > > - Changed the type of return value of i40e_enable_extended_tag() to 'v= oid'. > > > > diff --git a/doc/guides/rel_notes/release_16_04.rst > > b/doc/guides/rel_notes/release_16_04.rst > > index 5786f74..bed5779 100644 > > --- a/doc/guides/rel_notes/release_16_04.rst > > +++ b/doc/guides/rel_notes/release_16_04.rst > > @@ -46,6 +46,12 @@ This section should contain new features added in th= is > release. Sample format: > > > > * **Added vhost-user live migration support.** > > > > +* **i40e: Enabled extended tag.** > > + > > + It enabled extended tag by checking and writing corresponding PCI > > + config space bytes, to boost the performance. In the meanwhile, it > > + deprecated the legacy way via reading/writing sysfile supported by k= ernel > module of igb_uio. > > + >=20 > Hi Helin, >=20 > does this really need to go into the release notes? Is it a user-visible = change that > affects the user experience in any way? Previously we enable it in eal via igb_uio sys file (by default, it is disa= bled), which was deprecated now, and will be removed from next release. All now added into i40e PMD init only. Yes, user might see the performance boost without doing anything, which is = different from previous version of DPDK. I think it should be mentioned somewhere. Any better idea? Thanks, Helin >=20 > /Bruce