From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1C4582B9D for ; Wed, 9 Mar 2016 16:20:51 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 09 Mar 2016 07:20:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="930208979" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 09 Mar 2016 07:20:51 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 07:20:50 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 07:20:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002; Wed, 9 Mar 2016 23:20:48 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 0/3] i40e setting ether type of VLANs Thread-Index: AQHReEkybSV7oClh6k2fNSaYNzno8p9NMNGAgAQLawA= Date: Wed, 9 Mar 2016 15:20:47 +0000 Message-ID: References: <1453426623-8696-1-git-send-email-helin.zhang@intel.com> <1457338370-32744-1-git-send-email-helin.zhang@intel.com> <1571443.EPqn3bY1d6@xps13> In-Reply-To: <1571443.EPqn3bY1d6@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/3] i40e setting ether type of VLANs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 15:20:52 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, March 7, 2016 5:29 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/3] i40e setting ether type of VLANs >=20 > 2016-03-07 16:12, Helin Zhang: > > The patch set was branched off rel_16_04 of repo dpdk-next-net, on > > below commit. > > - commit 4ac366ba647909c3b71818f9be9db86ba5e871da > > nfp: fix non-x86 build >=20 > Currently, changes on ethdev are directly applied on dpdk.git. Won't it be reviewed by Bruce, and applied on his maintainer branch first? >=20 > > v2: > > - Used RTE_NEXT_ABI to avoid ABI change issue. >=20 > RTE_NEXT_ABI must be used only when it is really too difficult to keep th= e > compatibility with librte_compat. > Here you are just adding a parameter to some functions, so you should try > versionning the functions with the help of macros in librte_compat. Let me think it a little bit more. I don't think I have understood that versioning quite well. >=20 > About the API change, you want to be able to insert a QinQ inner-vlan, ri= ght? No, I just want to configure the ether type of vlan the hardware can recogn= ize, but not to insert a vlan. > The current comment of rte_eth_dev_set_vlan_ether_type is: > * Set the Outer VLAN Ether Type by an Ethernet device, it can be inserte= d to > * the VLAN Header. This is a register setup available on some Intel NIC,= not > * but all, please check the data sheet for availability. Yes, I agree with you the comments should be reworked. >=20 > 2 comments: > - you haven't changed "Outer VLAN" so the API description is wrong > - it is announced as something Intel-specific >=20 > About the new enum: > + * VLAN types to indicate if it is for single VLAN, inner VLAN or outer = VLAN. > + * Note that most of time single VLAN is treated the same as inner VLAN. >=20 > You cannot say "most of time" in an API. Accepted. >=20 > More generally, I am not convinced by the current VLAN API that you are > extending. > Why this function is not merged with rte_eth_dev_set_vlan_pvid? No, they are different. I am trying to configure the hardware recognized ether type of both inner and outer vlan, but not to configure the vlan itse= lf.