From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AD2A82BE5 for ; Fri, 11 Mar 2016 15:17:22 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 11 Mar 2016 06:17:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,320,1455004800"; d="scan'208";a="762360788" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 11 Mar 2016 06:17:03 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Mar 2016 06:17:02 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Mar 2016 06:17:02 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 11 Mar 2016 22:17:00 +0800 From: "Zhang, Helin" To: Thomas Monjalon , Panu Matilainen Thread-Topic: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type Thread-Index: AQHRe3MGmPFqcIawVEeNUapT81ei959TkrCAgAAAPoCAALbFIA== Date: Fri, 11 Mar 2016 14:17:00 +0000 Message-ID: References: <1457627793-8491-1-git-send-email-helin.zhang@intel.com> <1457686179-20435-2-git-send-email-helin.zhang@intel.com> <56E2A9B5.60605@redhat.com> <17578435.kLWYh0KOmD@xps13> In-Reply-To: <17578435.kLWYh0KOmD@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 14:17:23 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, March 11, 2016 7:20 PM > To: Panu Matilainen; Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting = ether > type >=20 > 2016-03-11 13:19, Panu Matilainen: > > On 03/11/2016 10:49 AM, Helin Zhang wrote: > > > -int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t > > > tag_type); > > > +int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, > > > + enum rte_vlan_type vlan_type, > > > + uint16_t tag_type); > > > +int rte_eth_dev_set_vlan_ether_type_v22(uint8_t port_id, uint16_t > > > +tag_type); int rte_eth_dev_set_vlan_ether_type_v1604(uint8_t port_id= , > > > + enum rte_vlan_type vlan_type, > > > + uint16_t tag_type); > > > > > > /** > > > * Set VLAN offload configuration on an Ethernet device > > > > Its nice to see people actually trying to be compatible on occasion :) > > > > However in this case there's not much point in doing so, because > > libethdev ABI has already been broken in this cycle: > > http://dpdk.org/browse/dpdk/commit/?id=3Dcfd2279ea6299826fe992028f1dffa= f > > 9fa7e7d0a > > > > In other words, the compatibility versions can never get invoked > > because all software built against libethdev needs to be rebuilt > > anyway because of the soname bump. Just drop the compat versions, no > > point carrying around something that cannot possibly get used. >=20 > Oh yes, you are right. > Sorry Helin for having required that extra work. > On the good side, you have learnt how to do it ;) Yes, as Thomas said, at leat l know how to do that, and the extra work was = not too big. Thomas, Panu, thank you very much for the great comments! Thomas, does that mean I just need to work out a new version and just let t= he ABI changes as is. No ABI annoucenment will be requried? No RTE_NEXT_ABI will b= e used? Regards, Helin