From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <helin.zhang@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 387F15588 for <dev@dpdk.org>; Fri, 18 Mar 2016 01:54:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 17 Mar 2016 17:54:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,352,1455004800"; d="scan'208";a="68659236" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 17 Mar 2016 17:54:33 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:54:33 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:54:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 08:54:31 +0800 From: "Zhang, Helin" <helin.zhang@intel.com> To: Aaron Conole <aconole@redhat.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> Thread-Topic: [PATCH 6/8] drivers/net/e1000/igb: Signed left shift operator Thread-Index: AQHRb/07uWk8YSmvekWnMuEPtdwtdZ9egVnA Date: Fri, 18 Mar 2016 00:54:30 +0000 Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9CC832@SHSMSX104.ccr.corp.intel.com> References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-7-git-send-email-aconole@redhat.com> In-Reply-To: <1456426121-21423-7-git-send-email-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWExMTFhZDAtMDliNS00YTM2LThkOGEtZDc4ZTk4ZGQ1YjVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkR0OTh2NG9zTG10bmJJSWpWZGdUYnBjajhJZUVKMjVhd08xZCtUdVRjamc9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 6/8] drivers/net/e1000/igb: Signed left shift operator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 18 Mar 2016 00:54:34 -0000 > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Helin > <helin.zhang@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com> > Subject: [PATCH 6/8] drivers/net/e1000/igb: Signed left shift operator >=20 > Tell the compiler to use an unsigned constant for the config shifts. >=20 > Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Helin Zhang <helin.zhang@intel.com> > --- > drivers/net/e1000/igb_pf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c inde= x > 1d00dda..afe80f5 100644 > --- a/drivers/net/e1000/igb_pf.c > +++ b/drivers/net/e1000/igb_pf.c > @@ -172,8 +172,8 @@ int igb_pf_host_configure(struct rte_eth_dev *eth_dev= ) > E1000_WRITE_REG(hw, E1000_VT_CTL, vtctl); >=20 > /* Enable pools reserved to PF only */ > - E1000_WRITE_REG(hw, E1000_VFRE, (~0) << vf_num); > - E1000_WRITE_REG(hw, E1000_VFTE, (~0) << vf_num); > + E1000_WRITE_REG(hw, E1000_VFRE, (~0U) << vf_num); > + E1000_WRITE_REG(hw, E1000_VFTE, (~0U) << vf_num); >=20 > /* PFDMA Tx General Switch Control Enables VMDQ loopback */ > if (hw->mac.type =3D=3D e1000_i350) > -- > 2.5.0