From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 79257275D for ; Fri, 22 Apr 2016 07:19:02 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 21 Apr 2016 22:19:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,516,1455004800"; d="scan'208";a="964048225" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 21 Apr 2016 22:19:01 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 21 Apr 2016 22:19:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 21 Apr 2016 22:19:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Fri, 22 Apr 2016 13:18:59 +0800 From: "Zhang, Helin" To: "Topel, Bjorn" , "dev@dpdk.org" CC: "david.marchand@6wind.com" , "Wu, Jingjing" Thread-Topic: [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts Thread-Index: AQHRm98HnmjO5tNGZEOzA6A+xdg8e5+VOwZw//+tW4CAAIgP4P//fi+AgACGeAA= Date: Fri, 22 Apr 2016 05:18:59 +0000 Message-ID: References: <1460645904-19565-1-git-send-email-bjorn.topel@intel.com> <1461250975-14437-1-git-send-email-bjorn.topel@intel.com>, <6B5F13689D63284BBB0B66A5B315C82DBAC5E2@IRSMSX103.ger.corp.intel.com>, <6B5F13689D63284BBB0B66A5B315C82DBAC621@IRSMSX103.ger.corp.intel.com> In-Reply-To: <6B5F13689D63284BBB0B66A5B315C82DBAC621@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDNhYmU1ZjUtN2UzMy00MDRmLTllYWEtMjljY2FiYjRmM2YxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJua1JpVnhscWpwa0RBTkQydjE5ODJxR2tSaUdwZnpmVkFBZnN1YkY5bEk9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 05:19:03 -0000 > -----Original Message----- > From: Topel, Bjorn > Sent: Friday, April 22, 2016 1:17 PM > To: Zhang, Helin ; dev@dpdk.org > Cc: david.marchand@6wind.com; Wu, Jingjing > Subject: RE: [PATCH v2] i40evf: Report error if HW CRC strip is disabled = for Linux > PF hosts >=20 > >> >> + /* For Linux PF hosts, VF has no ability to disable HW CRC st= rip, > >> >> + * and is implicitly enabled by the PF. > >> >> + */ > >> >> + if (!conf->rxmode.hw_strip_crc) { > >> >> + vf =3D > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > >> >> + if ((vf->version_major =3D=3D > I40E_VIRTCHNL_VERSION_MAJOR) && > >> >> + (vf->version_minor <=3D > I40E_VIRTCHNL_VERSION_MINOR)) { > >> >> + /* Peer is Linux PF host. */ > >> > Can you reword above comments? > >> > It just means the host is not DPDK PF host driver, it could be > >> > Linux driver, and possible others (e.g. FreeBSD, VMWARE?). > >> > >> Sure, I'll reword it! The broader question, however, is this correct > >> for non- Linux/non-DPDK PF drivers? > >> For FreeBSD I'll dig into the code, but for VMWARE (and I'd assume > >> Microsoft > >> Windows) it'll be harder. > >> > >> Do you have any insights on the behavior for the non-open i40e PF driv= ers? > >> > >> From the documentation [1], it's unclear whether non-Linux/non-DPDK > >> PF drivers are supported. My interpretation was that only DPDK and > >> Linux PF hosts are supported for Fortville NICs. > > I guess only DPDK is different, though I am not sure. > > As all other NIC drivers were developped by the same organization. > > Even assuming that FreeBSD supports both configuration, it will not be > > a problem, as DPDK just doesn't support, and nothing wrong. >=20 > I verified against the FreeBSD ixl-1.4.27 driver, and it behaves (in term= s of rxq > crcstrip) the same way. >=20 > It would be a problem if the non-Linux/non-DPDK drivers had it (rx crcstr= ip) > *disabled* by default. (Further, being able to actually change the settin= g from a > VF would be nice as well. :-)) This doesn't seem to be case, though. >=20 > So, I'll change the wording from "Linux PF hosts" to "non-DPDK PF host". = Would > that be OK? I would agree with you. :) Thank you! Helin >=20 >=20 > Bj=F6rn