From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6D549FBBC for ; Wed, 21 Dec 2016 06:44:50 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 20 Dec 2016 21:44:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,382,1477983600"; d="scan'208";a="45455642" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 20 Dec 2016 21:44:49 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Dec 2016 21:44:48 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Dec 2016 21:44:48 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Wed, 21 Dec 2016 13:44:46 +0800 From: "Zhang, Helin" To: Gregory Etelson CC: "dev@dpdk.org" Thread-Topic: [PATCH] i40e jumbo frames fix Thread-Index: AQHSW0lGdb+hoY3BfES15k5Jz/yilaER4yJQgAAALhCAAACbgA== Date: Wed, 21 Dec 2016 05:44:46 +0000 Message-ID: References: <6898922.CcrIbCjOjV@polaris> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e jumbo frames fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 05:44:50 -0000 > From: Gregory Etelson [mailto:gregory@weka.io] > Sent: Wednesday, December 21, 2016 1:16 PM > To: dev > Cc: Wu, Jingjing; Zhang, Helin > Subject: [PATCH] i40e jumbo frames fix The format of the title is not corect as requried by DPDK community. Please refer to other patches. >=20 > Allow i40e PF and VF ports to operate with Ethernet jumbo frames Can you help to explain what's the issue? I am a little bit confused. >=20 >=20 > Signed-off-by: Gregory Etelson >=20 > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- drivers/net/i40e/i40e_rxtx.c=20 > | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index aa306d6..cf814e9 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1784,7 +1784,7 @@ static int i40evf_dev_xstats_get(struct=20 > rte_eth_dev *dev, > * Check if the jumbo frame and maximum packet length are set correctly=20 > */ if (dev_data->dev_conf.rxmode.jumbo_frame =3D=3D 1) { > - if (rxq->max_pkt_len <=3D ETHER_MAX_LEN || > + if (rxq->max_pkt_len < ETHER_MAX_LEN || > rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) { > PMD_DRV_LOG(ERR, "maximum packet length must be " > "larger than %u and smaller than %u, as jumbo " > diff --git a/drivers/net/i40e/i40e_rxtx.c=20 > b/drivers/net/i40e/i40e_rxtx.c index > 7ae7d9f..8cb4655 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2324,7 +2324,7 @@ static inline int __attribute__((always_inline))=20 > len =3D > hw->func_caps.rx_buf_chain_len * rxq->rx_buf_len; > rxq->max_pkt_len =3D RTE_MIN(len, data->dev_conf.rxmode.max_rx_pkt_len); > if (data->dev_conf.rxmode.jumbo_frame =3D=3D 1) { > - if (rxq->max_pkt_len <=3D ETHER_MAX_LEN || > + if (rxq->max_pkt_len < ETHER_MAX_LEN || > rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) { > PMD_DRV_LOG(ERR, "maximum packet length must " > "be larger than %u and smaller than %u," > -- > 1.7.1 >=20 >=20 >