DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: zhouyangchao <zhouyates@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
Date: Tue, 19 Dec 2017 07:18:19 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACBE420@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <d3e3049c-f86b-402e-9e07-73c07cc4812c@zyc-PC.local>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Wednesday, November 29, 2017 10:50 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
Basically please follow the style of 'net/igb:', thanks!

/Helin
> 
> Internal variable containing the number of TX queues for a device, was being
> incorrectly assigned the number of RX queues, instead of TX.
> 
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
> 
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index fdc139f..a600fba 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
>  	enum rte_eth_rx_mq_mode rx_mq_mode = dev->data-
> >dev_conf.rxmode.mq_mode;
>  	enum rte_eth_tx_mq_mode tx_mq_mode = dev->data-
> >dev_conf.txmode.mq_mode;
>  	uint16_t nb_rx_q = dev->data->nb_rx_queues;
> -	uint16_t nb_tx_q = dev->data->nb_rx_queues;
> +	uint16_t nb_tx_q = dev->data->nb_tx_queues;
> 
>  	if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
>  	    tx_mq_mode == ETH_MQ_TX_DCB ||
> --
> 2.9.0.windows.1
> 
> 

  reply	other threads:[~2017-12-19  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  2:50 zhouyangchao
2017-12-19  7:18 ` Zhang, Helin [this message]
2017-12-19 12:22 ` Dai, Wei
2017-12-20  6:26   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACBE420@SHSMSX103.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=zhouyates@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).