* [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting
@ 2017-11-29 10:27 Qi Zhang
2017-11-30 6:53 ` Xing, Beilei
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2017-11-29 10:27 UTC (permalink / raw)
To: beilei.xing; +Cc: dev, Qi Zhang, stable
Vlan offload flag "rx_mode.hw_vlan_extend" should be considerred at
rte_eth_dev_configure stage as well as "rx_mode.hw_vlan_strip" and
"rx_mode.hw_vlan_filter".
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 811cc9f..0739f65 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -5315,15 +5315,15 @@ i40e_dev_init_vlan(struct rte_eth_dev *dev)
int mask = 0;
/* Apply vlan offload setting */
- mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK;
+ mask = ETH_VLAN_STRIP_MASK |
+ ETH_VLAN_FILTER_MASK |
+ ETH_VLAN_EXTEND_MASK;
ret = i40e_vlan_offload_set(dev, mask);
if (ret) {
PMD_DRV_LOG(INFO, "Failed to update vlan offload");
return ret;
}
- /* Apply double-vlan setting, not implemented yet */
-
/* Apply pvid setting */
ret = i40e_vlan_pvid_set(dev, data->dev_conf.txmode.pvid,
data->dev_conf.txmode.hw_vlan_insert_pvid);
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting
2017-11-29 10:27 [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting Qi Zhang
@ 2017-11-30 6:53 ` Xing, Beilei
2017-12-20 2:42 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Xing, Beilei @ 2017-11-30 6:53 UTC (permalink / raw)
To: Zhang, Qi Z; +Cc: dev, stable
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, November 29, 2017 6:28 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix VLAN offload setting
>
> Vlan offload flag "rx_mode.hw_vlan_extend" should be considerred at
> rte_eth_dev_configure stage as well as "rx_mode.hw_vlan_strip" and
> "rx_mode.hw_vlan_filter".
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting
2017-11-30 6:53 ` Xing, Beilei
@ 2017-12-20 2:42 ` Zhang, Helin
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2017-12-20 2:42 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Qi Z; +Cc: dev, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Thursday, November 30, 2017 2:53 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Wednesday, November 29, 2017 6:28 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/i40e: fix VLAN offload setting
> >
> > Vlan offload flag "rx_mode.hw_vlan_extend" should be considerred at
> > rte_eth_dev_configure stage as well as "rx_mode.hw_vlan_strip" and
> > "rx_mode.hw_vlan_filter".
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to next-net-intel. Thank you all! /Helin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-20 2:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 10:27 [dpdk-dev] [PATCH] net/i40e: fix VLAN offload setting Qi Zhang
2017-11-30 6:53 ` Xing, Beilei
2017-12-20 2:42 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).