* [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
@ 2017-12-09 1:55 Xiao Wang
2017-12-20 5:44 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Xiao Wang @ 2017-12-09 1:55 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, stable, Xiao Wang
When closing port, we need to send mailbox messages to switch manager
to reset multicast mode and delete logical port. In the latest IES_SDK,
e.g. v4.3.3, switch takes longer time to handle these mailbox messages.
So this patch adds longer delay to accommodate this change. Otherwise,
the mailbox will be closed before all the messages are handled, as a
result, the logical port remains in switch manager after port is closed.
Fixes: b961fe9344dd ("net/fm10k: fix MAC address removal from switch")
Cc: stable@dpdk.org
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 2d05a46..58dac38 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -54,7 +54,7 @@
/* Wait interval to get switch status */
#define WAIT_SWITCH_MSG_US 100000
/* A period of quiescence for switch */
-#define FM10K_SWITCH_QUIESCE_US 10000
+#define FM10K_SWITCH_QUIESCE_US 100000
/* Number of chars per uint32 type */
#define CHARS_PER_UINT32 (sizeof(uint32_t))
#define BIT_MASK_PER_UINT32 ((1 << CHARS_PER_UINT32) - 1)
@@ -1242,7 +1242,7 @@ static inline int fm10k_glort_valid(struct fm10k_hw *hw)
MAX_LPORT_NUM, false);
fm10k_mbx_unlock(hw);
- /* allow 10ms for device to quiesce */
+ /* allow 100ms for device to quiesce */
rte_delay_us(FM10K_SWITCH_QUIESCE_US);
/* Stop mailbox service first */
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
2017-12-09 1:55 [dpdk-dev] [PATCH] net/fm10k: fix logical port delete Xiao Wang
@ 2017-12-20 5:44 ` Zhang, Helin
2017-12-20 5:50 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2017-12-20 5:44 UTC (permalink / raw)
To: Wang, Xiao W, Zhang, Qi Z; +Cc: dev, stable, Wang, Xiao W
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> Sent: Saturday, December 9, 2017 9:56 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; stable@dpdk.org; Wang, Xiao W
> Subject: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
>
> When closing port, we need to send mailbox messages to switch manager to
> reset multicast mode and delete logical port. In the latest IES_SDK, e.g. v4.3.3,
> switch takes longer time to handle these mailbox messages.
>
> So this patch adds longer delay to accommodate this change. Otherwise, the
> mailbox will be closed before all the messages are handled, as a result, the
> logical port remains in switch manager after port is closed.
>
> Fixes: b961fe9344dd ("net/fm10k: fix MAC address removal from switch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
2017-12-20 5:44 ` Zhang, Helin
@ 2017-12-20 5:50 ` Zhang, Helin
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2017-12-20 5:50 UTC (permalink / raw)
To: Zhang, Helin, Wang, Xiao W, Zhang, Qi Z; +Cc: dev, stable, Wang, Xiao W
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Wednesday, December 20, 2017 1:44 PM
> To: Wang, Xiao W; Zhang, Qi Z
> Cc: dev@dpdk.org; stable@dpdk.org; Wang, Xiao W
> Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> > Sent: Saturday, December 9, 2017 9:56 AM
> > To: Zhang, Qi Z
> > Cc: dev@dpdk.org; stable@dpdk.org; Wang, Xiao W
> > Subject: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete
> >
> > When closing port, we need to send mailbox messages to switch manager
> > to reset multicast mode and delete logical port. In the latest
> > IES_SDK, e.g. v4.3.3, switch takes longer time to handle these mailbox
> messages.
> >
> > So this patch adds longer delay to accommodate this change. Otherwise,
> > the mailbox will be closed before all the messages are handled, as a
> > result, the logical port remains in switch manager after port is closed.
> >
> > Fixes: b961fe9344dd ("net/fm10k: fix MAC address removal from switch")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to next-net-intel. Thanks a lot! /Helin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-20 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-09 1:55 [dpdk-dev] [PATCH] net/fm10k: fix logical port delete Xiao Wang
2017-12-20 5:44 ` Zhang, Helin
2017-12-20 5:50 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).