From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6B3FB8E01 for ; Wed, 20 Dec 2017 09:24:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2017 00:24:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,431,1508828400"; d="scan'208";a="15107189" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2017 00:24:09 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Dec 2017 00:24:08 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Dec 2017 00:24:08 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 20 Dec 2017 16:24:07 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix FDIR input set conflict Thread-Index: AQHTd7/wS04rAxXbp0CG8fyQt7gGtqNKqNpQgAE/S7A= Date: Wed, 20 Dec 2017 08:24:06 +0000 Message-ID: References: <1513574457-47623-1-git-send-email-beilei.xing@intel.com> <039ED4275CED7440929022BC67E7061153122DB1@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153122DB1@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 08:24:10 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Tuesday, December 19, 2017 9:21 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Monday, December 18, 2017 1:21 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org > > Subject: [PATCH] net/i40e: fix FDIR input set conflict > > > > The first FDIR rule for some PCTYPE will configure input set and > > create flow, the following flows must use the same input set, > > otherwise will cause input set conflict and fail to create flow. > > But if creating the first rule after flow flush, input set should be > > re-configured. > > > > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > > c: stable@dpdk.org > > > > Signed-off-by: Beilei Xing > > --- > > drivers/net/i40e/i40e_flow.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 7e4936e..a9e7a0d 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4406,6 +4406,7 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > struct rte_eth_dev *dev =3D pf->adapter->eth_dev; > > struct i40e_fdir_info *fdir_info =3D &pf->fdir; > > struct i40e_fdir_filter *fdir_filter; > > + enum i40e_filter_pctype pctype; > > struct rte_flow *flow; > > void *temp; > > int ret; > > @@ -4427,6 +4428,10 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > rte_free(flow); > > } > > } > > + > > + for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > > + pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > > + pf->fdir.inset_flag[pctype] =3D 0; > > } > > > > return ret; > > -- > > 2.5.5 >=20 > Acked-by: Qi Zhang Applied to next-net-intel, thanks! /Helin