* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
@ 2018-01-09 6:15 ` Zhang, Helin
2018-01-09 6:17 ` Zhang, Helin
` (4 subsequent siblings)
5 siblings, 0 replies; 34+ messages in thread
From: Zhang, Helin @ 2018-01-09 6:15 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Mcnamara, John
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> ---
>
> v2:
> -change this information to v18.02 release notes.
>
> v3:
> -rework it on dpdk-next-net-intel sub tree.
> ---
> doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 621b8f5..d7c8b68 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -47,6 +47,24 @@ New Features
> users. According to the device configuration, it will setup TX->RX loopback
> link or not.
>
> +* **Added the i40e ethernet driver to support queue region feature.**
Please follow others about the format. I guess blank space might be needed.
Thanks,
Helin
> +
> + This feature enable queue regions configuration for RSS in PF, so
> + that different traffic classes or different packet classification
> + types can be separated to different queues in different queue
> + regions. This feature has been implemented in v17.11.
> +
> +* **Added the testpmd app to support queue region configuration with
> +CLI.**
> +
> + This patch add a API configuration of queue region in rss with command line.
> + It can parse the parameters of region index, queue number, queue
> + start index, user priority, traffic classes and so on.
> + According to commands from command line, it will call i40e private
> + API and start the process of set or flush queue region configure. As
> + this feature is specific for i40e, so private API will be used. Aslo
> + add a document for these new commands.
> + This feature has been implemented in v17.11.
> +
> API Changes
> -----------
>
> --
> 2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-01-09 6:15 ` Zhang, Helin
@ 2018-01-09 6:17 ` Zhang, Helin
2018-01-09 6:18 ` Zhao1, Wei
2018-01-09 6:26 ` Zhang, Helin
` (3 subsequent siblings)
5 siblings, 1 reply; 34+ messages in thread
From: Zhang, Helin @ 2018-01-09 6:17 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Mcnamara, John
> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:15 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:40 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > Subject: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > -change this information to v18.02 release notes.
> >
> > v3:
> > -rework it on dpdk-next-net-intel sub tree.
> > ---
> > doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > b/doc/guides/rel_notes/release_18_02.rst
> > index 621b8f5..d7c8b68 100644
> > --- a/doc/guides/rel_notes/release_18_02.rst
> > +++ b/doc/guides/rel_notes/release_18_02.rst
> > @@ -47,6 +47,24 @@ New Features
> > users. According to the device configuration, it will setup TX->RX loopback
> > link or not.
> >
> > +* **Added the i40e ethernet driver to support queue region feature.**
> Please follow others about the format. I guess blank space might be needed.
> Thanks,
> Helin
Sorry, it seems that different formats are all there. Please just ignore my comments here. Thanks!
/Helin
>
> > +
> > + This feature enable queue regions configuration for RSS in PF, so
> > + that different traffic classes or different packet classification
> > + types can be separated to different queues in different queue
> > + regions. This feature has been implemented in v17.11.
> > +
> > +* **Added the testpmd app to support queue region configuration with
> > +CLI.**
> > +
> > + This patch add a API configuration of queue region in rss with command
> line.
> > + It can parse the parameters of region index, queue number, queue
> > + start index, user priority, traffic classes and so on.
> > + According to commands from command line, it will call i40e private
> > + API and start the process of set or flush queue region configure.
> > + As this feature is specific for i40e, so private API will be used.
> > + Aslo add a document for these new commands.
> > + This feature has been implemented in v17.11.
> > +
> > API Changes
> > -----------
> >
> > --
> > 2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-09 6:17 ` Zhang, Helin
@ 2018-01-09 6:18 ` Zhao1, Wei
0 siblings, 0 replies; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-09 6:18 UTC (permalink / raw)
To: Zhang, Helin, dev; +Cc: Mcnamara, John
> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -----Original Message-----
> > From: Zhang, Helin
> > Sent: Tuesday, January 9, 2018 2:15 PM
> > To: Zhao1, Wei; dev@dpdk.org
> > Cc: Mcnamara, John
> > Subject: RE: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Monday, January 8, 2018 11:40 AM
> > > To: dev@dpdk.org
> > > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > > Subject: [PATCH v3] doc: add queue region feature info to release
> > > notes
> > >
> > > This patch add inforation about i40e queue region realted to release
> > > notes, it has been missed before in v17.11 release notes. This
> > > feature has been implemented in v17.11.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > >
> > > ---
> > >
> > > v2:
> > > -change this information to v18.02 release notes.
> > >
> > > v3:
> > > -rework it on dpdk-next-net-intel sub tree.
> > > ---
> > > doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > > b/doc/guides/rel_notes/release_18_02.rst
> > > index 621b8f5..d7c8b68 100644
> > > --- a/doc/guides/rel_notes/release_18_02.rst
> > > +++ b/doc/guides/rel_notes/release_18_02.rst
> > > @@ -47,6 +47,24 @@ New Features
> > > users. According to the device configuration, it will setup TX->RX
> loopback
> > > link or not.
> > >
> > > +* **Added the i40e ethernet driver to support queue region
> > > +feature.**
> > Please follow others about the format. I guess blank space might be
> needed.
> > Thanks,
> > Helin
> Sorry, it seems that different formats are all there. Please just ignore my
> comments here. Thanks!
Ok.
>
> /Helin
> >
> > > +
> > > + This feature enable queue regions configuration for RSS in PF,
> > > + so that different traffic classes or different packet
> > > + classification types can be separated to different queues in
> > > + different queue regions. This feature has been implemented in v17.11.
> > > +
> > > +* **Added the testpmd app to support queue region configuration
> > > +with
> > > +CLI.**
> > > +
> > > + This patch add a API configuration of queue region in rss with
> > > + command
> > line.
> > > + It can parse the parameters of region index, queue number, queue
> > > + start index, user priority, traffic classes and so on.
> > > + According to commands from command line, it will call i40e
> > > + private API and start the process of set or flush queue region configure.
> > > + As this feature is specific for i40e, so private API will be used.
> > > + Aslo add a document for these new commands.
> > > + This feature has been implemented in v17.11.
> > > +
> > > API Changes
> > > -----------
> > >
> > > --
> > > 2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-01-09 6:15 ` Zhang, Helin
2018-01-09 6:17 ` Zhang, Helin
@ 2018-01-09 6:26 ` Zhang, Helin
2018-01-09 6:29 ` Zhang, Helin
` (2 subsequent siblings)
5 siblings, 0 replies; 34+ messages in thread
From: Zhang, Helin @ 2018-01-09 6:26 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Mcnamara, John
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
` (2 preceding siblings ...)
2018-01-09 6:26 ` Zhang, Helin
@ 2018-01-09 6:29 ` Zhang, Helin
2018-01-16 21:53 ` Thomas Monjalon
2018-01-18 3:45 ` [dpdk-dev] [PATCH v4] " Wei Zhao
2018-01-19 3:28 ` Wei Zhao
5 siblings, 1 reply; 34+ messages in thread
From: Zhang, Helin @ 2018-01-09 6:29 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Mcnamara, John
> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:26 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:40 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > Subject: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, with minor changes. Thanks!
/Helin
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-09 6:29 ` Zhang, Helin
@ 2018-01-16 21:53 ` Thomas Monjalon
2018-01-18 2:00 ` Zhao1, Wei
0 siblings, 1 reply; 34+ messages in thread
From: Thomas Monjalon @ 2018-01-16 21:53 UTC (permalink / raw)
To: Zhang, Helin, Zhao1, Wei; +Cc: dev, Mcnamara, John, ferruh.yigit
> > > This patch add inforation about i40e queue region realted to release
> > > notes, it has been missed before in v17.11 release notes. This feature
> > > has been implemented in v17.11.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Acked-by: Helin Zhang <helin.zhang@intel.com>
> Applied to dpdk-next-net-intel, with minor changes. Thanks!
This patch has not been reviewed by John, doc maintainer.
There are some english errors.
It documents extensively a testpmd addition, which is usually not
documented in release notes.
And it is adding 17.11 features in 18.02 release notes.
It is too much, so it is just removed when pulling next-net.
If you want to explain what is possible with i40e, you should
document it in i40e.rst.
The release notes is just a short list of what is added.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-16 21:53 ` Thomas Monjalon
@ 2018-01-18 2:00 ` Zhao1, Wei
2018-01-18 7:30 ` Thomas Monjalon
0 siblings, 1 reply; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-18 2:00 UTC (permalink / raw)
To: Thomas Monjalon, Zhang, Helin; +Cc: dev, Mcnamara, John, Yigit, Ferruh
Hi, Thomas
I will update it in 17.11 release nots later as your comment.
And it has been CC to John, but not get any feedback.
Thanks.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, January 17, 2018 5:53 AM
> To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
>
> > > > This patch add inforation about i40e queue region realted to
> > > > release notes, it has been missed before in v17.11 release notes.
> > > > This feature has been implemented in v17.11.
> > > >
> > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > Applied to dpdk-next-net-intel, with minor changes. Thanks!
>
> This patch has not been reviewed by John, doc maintainer.
> There are some english errors.
> It documents extensively a testpmd addition, which is usually not
> documented in release notes.
> And it is adding 17.11 features in 18.02 release notes.
>
> It is too much, so it is just removed when pulling next-net.
>
> If you want to explain what is possible with i40e, you should document it in
> i40e.rst.
> The release notes is just a short list of what is added.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-18 2:00 ` Zhao1, Wei
@ 2018-01-18 7:30 ` Thomas Monjalon
2018-01-19 3:15 ` Zhao1, Wei
2018-01-19 3:38 ` Zhao1, Wei
0 siblings, 2 replies; 34+ messages in thread
From: Thomas Monjalon @ 2018-01-18 7:30 UTC (permalink / raw)
To: Zhao1, Wei; +Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, beilei.xing
You can probably work with Beilei who is trying to do the same thing
for other i40e features:
https://dpdk.org/dev/patchwork/patch/33953/
18/01/2018 03:00, Zhao1, Wei:
> Hi, Thomas
> I will update it in 17.11 release nots later as your comment.
> And it has been CC to John, but not get any feedback.
>
> Thanks.
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, January 17, 2018 5:53 AM
> > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> > release notes
> >
> > > > > This patch add inforation about i40e queue region realted to
> > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > This feature has been implemented in v17.11.
> > > > >
> > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> >
> > This patch has not been reviewed by John, doc maintainer.
> > There are some english errors.
> > It documents extensively a testpmd addition, which is usually not
> > documented in release notes.
> > And it is adding 17.11 features in 18.02 release notes.
> >
> > It is too much, so it is just removed when pulling next-net.
> >
> > If you want to explain what is possible with i40e, you should document it in
> > i40e.rst.
> > The release notes is just a short list of what is added.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-18 7:30 ` Thomas Monjalon
@ 2018-01-19 3:15 ` Zhao1, Wei
2018-01-19 9:13 ` Thomas Monjalon
2018-01-19 3:38 ` Zhao1, Wei
1 sibling, 1 reply; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-19 3:15 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
Hi, Thomas
Thank you! After discussion with Beilei, I have commit a new patch v4.
https://dpdk.org/dev/patchwork/patch/33956/
Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
Do you think this is ok?
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, January 18, 2018 3:30 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
>
> You can probably work with Beilei who is trying to do the same thing for
> other i40e features:
> https://dpdk.org/dev/patchwork/patch/33953/
>
>
> 18/01/2018 03:00, Zhao1, Wei:
> > Hi, Thomas
> > I will update it in 17.11 release nots later as your comment.
> > And it has been CC to John, but not get any feedback.
> >
> > Thanks.
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: Wednesday, January 17, 2018 5:53 AM
> > > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > > <wei.zhao1@intel.com>
> > > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > > Ferruh <ferruh.yigit@intel.com>
> > > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature
> > > info to release notes
> > >
> > > > > > This patch add inforation about i40e queue region realted to
> > > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > > This feature has been implemented in v17.11.
> > > > > >
> > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> > >
> > > This patch has not been reviewed by John, doc maintainer.
> > > There are some english errors.
> > > It documents extensively a testpmd addition, which is usually not
> > > documented in release notes.
> > > And it is adding 17.11 features in 18.02 release notes.
> > >
> > > It is too much, so it is just removed when pulling next-net.
> > >
> > > If you want to explain what is possible with i40e, you should
> > > document it in i40e.rst.
> > > The release notes is just a short list of what is added.
>
>
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-19 3:15 ` Zhao1, Wei
@ 2018-01-19 9:13 ` Thomas Monjalon
2018-01-19 9:17 ` Thomas Monjalon
0 siblings, 1 reply; 34+ messages in thread
From: Thomas Monjalon @ 2018-01-19 9:13 UTC (permalink / raw)
To: Zhao1, Wei; +Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
19/01/2018 04:15, Zhao1, Wei:
> Hi, Thomas
> Thank you! After discussion with Beilei, I have commit a new patch v4.
> https://dpdk.org/dev/patchwork/patch/33956/
> Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
> Do you think this is ok?
Yes it is fine to wait for John's approval.
Note: in release notes, you should group all i40e features in the same place.
In v4, you just added it at the end.
I think v5 is needed.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-19 9:13 ` Thomas Monjalon
@ 2018-01-19 9:17 ` Thomas Monjalon
2018-01-22 1:58 ` Zhao1, Wei
2018-01-22 5:30 ` Zhao1, Wei
0 siblings, 2 replies; 34+ messages in thread
From: Thomas Monjalon @ 2018-01-19 9:17 UTC (permalink / raw)
To: Zhao1, Wei; +Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
19/01/2018 10:13, Thomas Monjalon:
> 19/01/2018 04:15, Zhao1, Wei:
> > Hi, Thomas
> > Thank you! After discussion with Beilei, I have commit a new patch v4.
> > https://dpdk.org/dev/patchwork/patch/33956/
> > Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
> > Do you think this is ok?
>
> Yes it is fine to wait for John's approval.
>
> Note: in release notes, you should group all i40e features in the same place.
> In v4, you just added it at the end.
> I think v5 is needed.
More precisions:
There is no i40e block in 17.11 release notes.
So you should insert one close to other net devices,
for instance, after the bnxt one.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-19 9:17 ` Thomas Monjalon
@ 2018-01-22 1:58 ` Zhao1, Wei
2018-01-22 5:30 ` Zhao1, Wei
1 sibling, 0 replies; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-22 1:58 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
Ok, good idea, v5 will come later.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
>
> 19/01/2018 10:13, Thomas Monjalon:
> > 19/01/2018 04:15, Zhao1, Wei:
> > > Hi, Thomas
> > > Thank you! After discussion with Beilei, I have commit a new patch v4.
> > > https://dpdk.org/dev/patchwork/patch/33956/
> > > Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> > > Do you think this is ok?
> >
> > Yes it is fine to wait for John's approval.
> >
> > Note: in release notes, you should group all i40e features in the same place.
> > In v4, you just added it at the end.
> > I think v5 is needed.
>
> More precisions:
> There is no i40e block in 17.11 release notes.
> So you should insert one close to other net devices, for instance, after the
> bnxt one.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-19 9:17 ` Thomas Monjalon
2018-01-22 1:58 ` Zhao1, Wei
@ 2018-01-22 5:30 ` Zhao1, Wei
1 sibling, 0 replies; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-22 5:30 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
HI, Thomas
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
>
> 19/01/2018 10:13, Thomas Monjalon:
> > 19/01/2018 04:15, Zhao1, Wei:
> > > Hi, Thomas
> > > Thank you! After discussion with Beilei, I have commit a new patch v4.
> > > https://dpdk.org/dev/patchwork/patch/33956/
> > > Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> > > Do you think this is ok?
> >
> > Yes it is fine to wait for John's approval.
> >
> > Note: in release notes, you should group all i40e features in the same place.
> > In v4, you just added it at the end.
> > I think v5 is needed.
>
> More precisions:
> There is no i40e block in 17.11 release notes.
> So you should insert one close to other net devices, for instance, after the
> bnxt one.
Thank you for your help!
I have commit a v5 patch https://dpdk.org/dev/patchwork/patch/34211/
It is based on beilei xing patch https://dpdk.org/dev/patchwork/patch/33953/
I have add i40e comment after hers.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes
2018-01-18 7:30 ` Thomas Monjalon
2018-01-19 3:15 ` Zhao1, Wei
@ 2018-01-19 3:38 ` Zhao1, Wei
1 sibling, 0 replies; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-19 3:38 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Zhang, Helin, dev, Mcnamara, John, Yigit, Ferruh, Xing, Beilei
Commit second time to cc stable@dpdk.org
https://dpdk.org/dev/patchwork/patch/34065/
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, January 19, 2018 11:15 AM
> To: 'Thomas Monjalon' <thomas@monjalon.net>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
>
> Hi, Thomas
> Thank you! After discussion with Beilei, I have commit a new patch v4.
> https://dpdk.org/dev/patchwork/patch/33956/
> Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> Do you think this is ok?
>
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Thursday, January 18, 2018 3:30 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>
> > Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara,
> John
> > <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info
> > to release notes
> >
> > You can probably work with Beilei who is trying to do the same thing
> > for other i40e features:
> > https://dpdk.org/dev/patchwork/patch/33953/
> >
> >
> > 18/01/2018 03:00, Zhao1, Wei:
> > > Hi, Thomas
> > > I will update it in 17.11 release nots later as your comment.
> > > And it has been CC to John, but not get any feedback.
> > >
> > > Thanks.
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > Sent: Wednesday, January 17, 2018 5:53 AM
> > > > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > > > <wei.zhao1@intel.com>
> > > > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > > > Ferruh <ferruh.yigit@intel.com>
> > > > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature
> > > > info to release notes
> > > >
> > > > > > > This patch add inforation about i40e queue region realted to
> > > > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > > > This feature has been implemented in v17.11.
> > > > > > >
> > > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> > > >
> > > > This patch has not been reviewed by John, doc maintainer.
> > > > There are some english errors.
> > > > It documents extensively a testpmd addition, which is usually not
> > > > documented in release notes.
> > > > And it is adding 17.11 features in 18.02 release notes.
> > > >
> > > > It is too much, so it is just removed when pulling next-net.
> > > >
> > > > If you want to explain what is possible with i40e, you should
> > > > document it in i40e.rst.
> > > > The release notes is just a short list of what is added.
> >
> >
^ permalink raw reply [flat|nested] 34+ messages in thread
* [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
` (3 preceding siblings ...)
2018-01-09 6:29 ` Zhang, Helin
@ 2018-01-18 3:45 ` Wei Zhao
2018-01-19 3:28 ` Wei Zhao
5 siblings, 0 replies; 34+ messages in thread
From: Wei Zhao @ 2018-01-18 3:45 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara, Wei Zhao
This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-change this information to v18.02 release notes.
v3:
-rework it on dpdk-next-net-intel sub tree.
v4:
-rework it into 17.11 release notes and i40e.rst
---
doc/guides/nics/i40e.rst | 24 +++++++++++++++++++++++-
doc/guides/rel_notes/release_17_11.rst | 6 ++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..345abf3 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
- IEEE1588/802.1AS timestamping
- VF Daemon (VFD) - EXPERIMENTAL
- Dynamic Device Personalization (DDP)
-
+- Queue region configuration
Prerequisites
-------------
@@ -430,6 +430,28 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
testpmd> port config 0 pctype 43 hash_inset set field 14
testpmd> port config 0 pctype 43 hash_inset set field 15
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 support a feature of queue regions
+configuration for RSS in PF, so that different traffic classes or different
+packet classification types can be separated to different queues in different
+queue regions. There is an API for configuration of queue region in rss with
+command line. It can parse the parameters of region index, queue number, queue
+start index, user priority, traffic classes and so on. According to commands
+from command line, it will call i40e private API and start the process of set
+or flush queue region configuration. As this feature is specific for i40e, so
+private API is used. These new commands are as below, for details please reference to
+document testpmd_funcs.rst.
+
+.. code-block:: console
+
+ testpmd> set port (port_id) queue-region region_id (value) \
+ queue_start_index (value) queue_num (value)
+ testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+ testpmd> set port (port_id) queue-region UP (value) region_id (value)
+ testpmd> set port (port_id) queue-region flush (on|off)
+ testpmd> show port (port_id) queue-region
+
Limitations or Known issues
---------------------------
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 016a08c..15321d6 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -273,6 +273,12 @@ New Features
applications to classify an input packet by matching it against a set of
flow rules. It uses the ``librte_table`` API to manage the flow rules.
+* **Added the i40e ethernet driver to support queue region feature.**
+
+ This feature enable queue regions configuration for RSS in PF,
+ so that different traffic classes or different packet
+ classification types can be separated into different queues in
+ different queue regions.
Resolved Issues
---------------
--
2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread* [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes
2018-01-08 3:39 ` [dpdk-dev] [PATCH v3] " Wei Zhao
` (4 preceding siblings ...)
2018-01-18 3:45 ` [dpdk-dev] [PATCH v4] " Wei Zhao
@ 2018-01-19 3:28 ` Wei Zhao
2018-01-21 21:22 ` Mcnamara, John
2018-01-22 5:18 ` [dpdk-dev] [PATCH v5] " Wei Zhao
5 siblings, 2 replies; 34+ messages in thread
From: Wei Zhao @ 2018-01-19 3:28 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara, stable, Wei Zhao
This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-change this information to v18.02 release notes.
v3:
-rework it on dpdk-next-net-intel sub tree.
v4:
-rework it into 17.11 release notes and i40e.rst
---
doc/guides/nics/i40e.rst | 24 +++++++++++++++++++++++-
doc/guides/rel_notes/release_17_11.rst | 6 ++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..345abf3 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
- IEEE1588/802.1AS timestamping
- VF Daemon (VFD) - EXPERIMENTAL
- Dynamic Device Personalization (DDP)
-
+- Queue region configuration
Prerequisites
-------------
@@ -430,6 +430,28 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
testpmd> port config 0 pctype 43 hash_inset set field 14
testpmd> port config 0 pctype 43 hash_inset set field 15
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 support a feature of queue regions
+configuration for RSS in PF, so that different traffic classes or different
+packet classification types can be separated to different queues in different
+queue regions. There is an API for configuration of queue region in rss with
+command line. It can parse the parameters of region index, queue number, queue
+start index, user priority, traffic classes and so on. According to commands
+from command line, it will call i40e private API and start the process of set
+or flush queue region configuration. As this feature is specific for i40e, so
+private API is used. These new commands are as below, for details please reference to
+document testpmd_funcs.rst.
+
+.. code-block:: console
+
+ testpmd> set port (port_id) queue-region region_id (value) \
+ queue_start_index (value) queue_num (value)
+ testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+ testpmd> set port (port_id) queue-region UP (value) region_id (value)
+ testpmd> set port (port_id) queue-region flush (on|off)
+ testpmd> show port (port_id) queue-region
+
Limitations or Known issues
---------------------------
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 016a08c..15321d6 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -273,6 +273,12 @@ New Features
applications to classify an input packet by matching it against a set of
flow rules. It uses the ``librte_table`` API to manage the flow rules.
+* **Added the i40e ethernet driver to support queue region feature.**
+
+ This feature enable queue regions configuration for RSS in PF,
+ so that different traffic classes or different packet
+ classification types can be separated into different queues in
+ different queue regions.
Resolved Issues
---------------
--
2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes
2018-01-19 3:28 ` Wei Zhao
@ 2018-01-21 21:22 ` Mcnamara, John
2018-01-22 5:27 ` Zhao1, Wei
2018-01-22 5:18 ` [dpdk-dev] [PATCH v5] " Wei Zhao
1 sibling, 1 reply; 34+ messages in thread
From: Mcnamara, John @ 2018-01-21 21:22 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, January 19, 2018 3:28 AM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v4] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to release
> notes, it has been missed before in v17.11 release notes. This feature has
> been implemented in v17.11.
>
Here is a suggested reworking with minor changes and a link to the testpmd docs:
Queue region configuration
~~~~~~~~~~~~~~~~~~~~~~~~~~
The Ethernet Controller X710/XL710 supports a feature of queue regions
configuration for RSS in the PF, so that different traffic classes or
different packet classification types can be separated to different queues in
different queue regions. There is an API for configuration of queue regions in
RSS with a command line. It can parse the parameters of the region index,
queue number, queue start index, user priority, traffic classes and so
on. Depending on commands from the command line, it will call i40e private
APIs and start the process of setting or flushing the queue region
configuration. As this feature is specific for i40e only private APIs are
used. These new ``test_pmd`` commands are as shown below. For details please
refer to :doc:`../testpmd_app_ug/index`.
.. code-block:: console
testpmd> set port (port_id) queue-region region_id (value) \
queue_start_index (value) queue_num (value)
testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
testpmd> set port (port_id) queue-region UP (value) region_id (value)
testpmd> set port (port_id) queue-region flush (on|off)
testpmd> show port (port_id) queue-region
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes
2018-01-21 21:22 ` Mcnamara, John
@ 2018-01-22 5:27 ` Zhao1, Wei
0 siblings, 0 replies; 34+ messages in thread
From: Zhao1, Wei @ 2018-01-22 5:27 UTC (permalink / raw)
To: Mcnamara, John, dev; +Cc: stable
Thank you for your help!
I have commit a v5 patch https://dpdk.org/dev/patchwork/patch/34211/
> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, January 22, 2018 5:22 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v4] doc: add queue region feature info to release notes
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, January 19, 2018 3:28 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org;
> Zhao1,
> > Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v4] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
>
> Here is a suggested reworking with minor changes and a link to the testpmd
> docs:
>
> Queue region configuration
> ~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The Ethernet Controller X710/XL710 supports a feature of queue regions
> configuration for RSS in the PF, so that different traffic classes or different
> packet classification types can be separated to different queues in different
> queue regions. There is an API for configuration of queue regions in RSS with
> a command line. It can parse the parameters of the region index, queue
> number, queue start index, user priority, traffic classes and so on. Depending
> on commands from the command line, it will call i40e private APIs and start
> the process of setting or flushing the queue region configuration. As this
> feature is specific for i40e only private APIs are used. These new ``test_pmd``
> commands are as shown below. For details please refer
> to :doc:`../testpmd_app_ug/index`.
>
> .. code-block:: console
>
> testpmd> set port (port_id) queue-region region_id (value) \
> queue_start_index (value) queue_num (value)
> testpmd> set port (port_id) queue-region region_id (value) flowtype
> (value)
> testpmd> set port (port_id) queue-region UP (value) region_id (value)
> testpmd> set port (port_id) queue-region flush (on|off)
> testpmd> show port (port_id) queue-region
>
>
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes
2018-01-19 3:28 ` Wei Zhao
2018-01-21 21:22 ` Mcnamara, John
@ 2018-01-22 5:18 ` Wei Zhao
2018-01-23 10:22 ` Mcnamara, John
1 sibling, 1 reply; 34+ messages in thread
From: Wei Zhao @ 2018-01-22 5:18 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara, thomas, stable, Wei Zhao
This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-change this information to v18.02 release notes.
v3:
-rework it on dpdk-next-net-intel sub tree.
v4:
-rework it into 17.11 release notes and i40e.rst.
v5:
-change some use of words and comment location in file.
---
doc/guides/nics/i40e.rst | 25 ++++++++++++++++++++++++-
doc/guides/rel_notes/release_17_11.rst | 7 +++++++
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..29601f1 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
- IEEE1588/802.1AS timestamping
- VF Daemon (VFD) - EXPERIMENTAL
- Dynamic Device Personalization (DDP)
-
+- Queue region configuration
Prerequisites
-------------
@@ -430,6 +430,29 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
testpmd> port config 0 pctype 43 hash_inset set field 14
testpmd> port config 0 pctype 43 hash_inset set field 15
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 supports a feature of queue regions
+configuration for RSS in the PF, so that different traffic classes or
+different packet classification types can be separated to different
+queues in different queue regions. There is an API for configuration
+of queue regions in RSS with a command line. It can parse the parameters
+of the region index, queue number, queue start index, user priority, traffic
+classes and so on. Depending on commands from the command line, it will call
+i40e private APIs and start the process of setting or flushing the queue
+region configuration. As this feature is specific for i40e only private
+APIs are used. These new ``test_pmd`` commands are as shown below. For
+details please refer to :doc:`../testpmd_app_ug/index`.
+
+.. code-block:: console
+
+ testpmd> set port (port_id) queue-region region_id (value) \
+ queue_start_index (value) queue_num (value)
+ testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+ testpmd> set port (port_id) queue-region UP (value) region_id (value)
+ testpmd> set port (port_id) queue-region flush (on|off)
+ testpmd> show port (port_id) queue-region
+
Limitations or Known issues
---------------------------
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index c37c71a..088778b 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -216,6 +216,13 @@ New Features
profiles which can be programmed by dynamic device personalization (DDP)
process.
+* **Added the i40e ethernet driver to support queue region feature.**
+
+ This feature enable queue regions configuration for RSS in PF,
+ so that different traffic classes or different packet
+ classification types can be separated into different queues in
+ different queue regions.
+
* **Updated ipsec-secgw application to support rte_security.**
Updated the ``ipsec-secgw`` sample application to support ``rte_security``
--
2.9.3
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes
2018-01-22 5:18 ` [dpdk-dev] [PATCH v5] " Wei Zhao
@ 2018-01-23 10:22 ` Mcnamara, John
2018-01-23 15:01 ` Zhang, Helin
0 siblings, 1 reply; 34+ messages in thread
From: Mcnamara, John @ 2018-01-23 10:22 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: thomas, stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 22, 2018 5:19 AM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; thomas@monjalon.net;
> stable@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v5] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to release
> notes, it has been missed before in v17.11 release notes. This feature has
> been implemented in v17.11.
>
> ...
> +Queue region configuration
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~
The underline for a section header should match the length of the text
and should be followed by a blank line, line in my suggested changes.
See also: http://dpdk.org/doc/guides/contributing/documentation.html#section-headers
However, this isn't an error so:
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes
2018-01-23 10:22 ` Mcnamara, John
@ 2018-01-23 15:01 ` Zhang, Helin
0 siblings, 0 replies; 34+ messages in thread
From: Zhang, Helin @ 2018-01-23 15:01 UTC (permalink / raw)
To: Mcnamara, John, Zhao1, Wei, dev; +Cc: thomas, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, January 23, 2018 6:22 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: thomas@monjalon.net; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to
> release notes
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 22, 2018 5:19 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; thomas@monjalon.net;
> > stable@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v5] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > ...
> > +Queue region configuration
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The underline for a section header should match the length of the text and
> should be followed by a blank line, line in my suggested changes.
>
> See also:
> http://dpdk.org/doc/guides/contributing/documentation.html#section-
> headers
>
> However, this isn't an error so:
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied to dpdk-next-net-intel, with commit log changes. Thanks!
/Helin
>
>
^ permalink raw reply [flat|nested] 34+ messages in thread