From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AC45544C7; Sat, 13 Jan 2018 07:27:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 22:27:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,351,1511856000"; d="scan'208";a="20666762" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 12 Jan 2018 22:27:31 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 22:27:31 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 22:27:30 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Sat, 13 Jan 2018 14:27:28 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Dai, Wei" , "Wang, Liang-min" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Thread-Index: AQHTf4yCMw5f90K3okOEX0BepscAE6Nxb+BA Importance: high X-Priority: 1 Date: Sat, 13 Jan 2018 06:27:28 +0000 Message-ID: References: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 06:27:33 -0000 Hi Qi Could you help to rebase on the latest dpdk-next-net-intel? It cannot be ap= plied now. Thanks! Regards, Helin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler >=20 > Mailbox interrupt handler only take care of PF reset notification, for ot= her > message ixgbe_read_mbx should not be called since it get chance to break = the > foreground VF to PF communication. > This can be simply repeated by > testpmd>rx_vlan rm all 0 >=20 > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link > up/down") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ff19a56..02121f4 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct > rte_eth_dev *dev) > struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > u32 in_msg =3D 0; >=20 > - if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) > - return; > + /* peek the message first */ > + in_msg =3D IXGBE_READ_REG(hw, IXGBE_VFMBMEM); >=20 > /* PF reset VF event */ > - if (in_msg =3D=3D IXGBE_PF_CONTROL_MSG) > + if (in_msg =3D=3D IXGBE_PF_CONTROL_MSG) { > + /* dummy mbx read to ack pf */ > + if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) > + return; > _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, > NULL, NULL); > + } > } >=20 > static int > -- > 2.7.4