From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CCFF27D19 for ; Sat, 13 Jan 2018 07:34:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 22:34:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,352,1511856000"; d="scan'208";a="20668620" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 12 Jan 2018 22:34:00 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 22:34:00 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 22:34:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Sat, 13 Jan 2018 14:33:58 +0800 From: "Zhang, Helin" To: "Lu, Wenzhuo" , "chas3@att.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit Thread-Index: AQHTirUo9O9QNyPx70G9vhSpr6UC6KNxW1pQ Date: Sat, 13 Jan 2018 06:33:58 +0000 Message-ID: References: <20171020032339.24079-1-3chas3@gmail.com> <1515658974-63940-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1515658974-63940-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 06:34:02 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, January 11, 2018 4:23 PM > To: chas3@att.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive a= nd > transmit >=20 > Hi, >=20 > > Date: Thu, 19 Oct 2017 23:23:39 -0400 > > > > From: Chas Williams > > > > The transmit and receive controller state machines are only enabled > > after receiving an interrupt and the link status is now valid. If an > > adapter is being used in conjunction with NC-SI, network controller > > sideband interface, the adapter may never get a link state change > > interrupt since the adapter's PHY is always link up and never changes s= tate. > > > > To fix this, always enable and disable the transmit and receive with > > .dev_start and .dev_stop. This is a better match for what is > > typically done with the other PMD's. Since we may never get an > > interrupt to check the link state, we also poll once at the end of > > .dev_start to get the current link status. > > > > Signed-off-by: Chas Williams > Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel, thanks! /Helin