From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D01B61B019 for ; Wed, 17 Jan 2018 16:03:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 07:03:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="194094300" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 17 Jan 2018 07:03:50 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 17 Jan 2018 07:03:50 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 17 Jan 2018 07:03:50 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 17 Jan 2018 23:03:48 +0800 From: "Zhang, Helin" To: Tushar Mulkar , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv Thread-Index: AQHTjhEz+ekru50vuESX9YaZIPA1CqN3xOEggABnEGA= Date: Wed, 17 Jan 2018 15:03:48 +0000 Message-ID: References: <20180115145739.122013-1-tmulkar@sandvine.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 15:03:52 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tushar Mulkar > Sent: Wednesday, January 17, 2018 4:53 PM > To: dev@dpdk.org > Cc: Xing, Beilei; Zhang, Qi Z; Tushar Mulkar > Subject: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethd= ev_vf > drv >=20 > The check for bool was accounting unwanted bits in the calulation of trut= h > value Could you help to add a bit more about the problem statement? >=20 > Signed-off-by: Tushar Mulkar > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index b96d77a0c..9c14ea278 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2095,7 +2095,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, > } > /* full duplex only */ > new_link.link_duplex =3D ETH_LINK_FULL_DUPLEX; > - new_link.link_status =3D vf->link_up ? ETH_LINK_UP : > + new_link.link_status =3D (vf->link_up & true) ? ETH_LINK_UP : > ETH_LINK_DOWN; Basically 'link_up' is in bool type, why adding bit manipulation on it? But thanks for your patches! /Helin > new_link.link_autoneg =3D > dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED; > -- > 2.11.0