From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C5F801B168; Sat, 20 Jan 2018 10:51:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2018 01:51:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,385,1511856000"; d="scan'208";a="197292809" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 20 Jan 2018 01:51:08 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 20 Jan 2018 01:51:08 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 20 Jan 2018 01:51:07 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Sat, 20 Jan 2018 17:51:05 +0800 From: "Zhang, Helin" To: "Xu, Rosen" , "Xing, Beilei" , "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD Thread-Index: AQHTkNI++X5fHCDux02ytGvHv+t9UaN8hjJg Date: Sat, 20 Jan 2018 09:51:04 +0000 Message-ID: References: <1516330925-27845-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1516330925-27845-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2018 09:51:10 -0000 Hi Rosen You may need to split the patches into 3, one per each PMD. Also please get it reviewed by maintainers, and do/fix any patchwork check = issues. Thanks! /Helin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > Sent: Friday, January 19, 2018 11:02 AM > To: Xing, Beilei; Zhang, Qi Z; Lu, Wenzhuo > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf > field initialization in PMD >=20 > Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL when > the mbuf is initialized or stored inside the mempool (unused). > All of these are done in rte_pktmbuf_pool_create() and > rte_pktmbuf_prefree_seg(). > So we remove the redundant code from i40e, ixgbe and avf module. >=20 > Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rosen Xu > --- > drivers/net/avf/avf_rxtx.c | 6 ------ > drivers/net/i40e/i40e_rxtx.c | 6 ------ > drivers/net/ixgbe/ixgbe_rxtx.c | 1 - > 3 files changed, 13 deletions(-) >=20 > diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c inde= x > e0c4583..b9051d6 100644 > --- a/drivers/net/avf/avf_rxtx.c > +++ b/drivers/net/avf/avf_rxtx.c > @@ -221,10 +221,7 @@ > return -ENOMEM; > } >=20 > - rte_mbuf_refcnt_set(mbuf, 1); > - mbuf->next =3D NULL; > mbuf->data_off =3D RTE_PKTMBUF_HEADROOM; > - mbuf->nb_segs =3D 1; > mbuf->port =3D rxq->port_id; >=20 > dma_addr =3D > @@ -1239,10 +1236,7 @@ > rte_prefetch0(rxep[i + 1]); >=20 > mb =3D rxep[i]; > - rte_mbuf_refcnt_set(mb, 1); > - mb->next =3D NULL; > mb->data_off =3D RTE_PKTMBUF_HEADROOM; > - mb->nb_segs =3D 1; > mb->port =3D rxq->port_id; > dma_addr =3D > rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb)); > rxdp[i].read.hdr_addr =3D 0; > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 23256b7..b578957 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -550,10 +550,7 @@ > rte_prefetch0(rxep[i + 1].mbuf); >=20 > mb =3D rxep[i].mbuf; > - rte_mbuf_refcnt_set(mb, 1); > - mb->next =3D NULL; > mb->data_off =3D RTE_PKTMBUF_HEADROOM; > - mb->nb_segs =3D 1; > mb->port =3D rxq->port_id; > dma_addr =3D rte_cpu_to_le_64(\ > rte_mbuf_data_iova_default(mb)); > @@ -2411,10 +2408,7 @@ > return -ENOMEM; > } >=20 > - rte_mbuf_refcnt_set(mbuf, 1); > - mbuf->next =3D NULL; > mbuf->data_off =3D RTE_PKTMBUF_HEADROOM; > - mbuf->nb_segs =3D 1; > mbuf->port =3D rxq->port_id; >=20 > dma_addr =3D > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index 4b38247..72da571 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1629,7 +1629,6 @@ uint16_t ixgbe_xmit_fixed_burst_vec(void > *tx_queue, struct rte_mbuf **tx_pkts, > mb->port =3D rxq->port_id; > } >=20 > - rte_mbuf_refcnt_set(mb, 1); > mb->data_off =3D RTE_PKTMBUF_HEADROOM; >=20 > /* populate the descriptors */ > -- > 1.8.3.1