From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7DCCD2BB5 for ; Wed, 24 Jan 2018 09:41:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 00:41:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,406,1511856000"; d="scan'208";a="13783719" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 24 Jan 2018 00:41:18 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 00:41:18 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 24 Jan 2018 16:41:16 +0800 From: "Zhang, Helin" To: Yong Wang , "Xing, Beilei" , "Lu, Wenzhuo" , "Trahe, Fiona" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak Thread-Index: AQHTk/eTLEHQOa12a0uwnSEp/LUbl6OCtVbQ Date: Wed, 24 Jan 2018 08:41:15 +0000 Message-ID: References: <1516675500-10878-1-git-send-email-wang.yong19@zte.com.cn> In-Reply-To: <1516675500-10878-1-git-send-email-wang.yong19@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 08:41:19 -0000 Hi Yong Thank you so much for your contribution! I have comments in general. 1. for a patch set, you need a cover letter for the series. 2. If a patch is to fix a bug/issue, the title should start with 'fix'. 3. A 'Fixes:' line is needed for any bug fixes. 4. A 'Cc:' line is needed, if the patch should be back ported into any stab= le release version. 5. you can find some good examples from the 'git log'. Thanks! Regards, Helin