From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B91DC1B640 for ; Fri, 26 Jan 2018 10:37:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 01:37:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="29648299" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 26 Jan 2018 01:37:48 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Jan 2018 01:37:47 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Jan 2018 01:37:47 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.192]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 17:37:45 +0800 From: "Zhang, Helin" To: "Xing, Beilei" , Yong Wang CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem leak Thread-Index: AQHTlb5gIutnDft60kORJDZmdomBaaOFmJIQgABOXxA= Date: Fri, 26 Jan 2018 09:37:45 +0000 Message-ID: References: <1516870864-12005-1-git-send-email-wang.yong19@zte.com.cn> <94479800C636CB44BD422CB454846E01320A0356@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E01320A0356@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 09:37:51 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > Sent: Friday, January 26, 2018 12:58 PM > To: Yong Wang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix= mem > leak >=20 > > -----Original Message----- > > From: Yong Wang [mailto:wang.yong19@zte.com.cn] > > Sent: Thursday, January 25, 2018 5:01 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Yong Wang > > Subject: [PATCH v4] net/i40e: add null point check and fix mem leak > > > > There are several func calls to rte_zmalloc() which don't do null > > point check on the return value. And before return, the memory is not > > freed. Fix it by adding null point check and rte_free(). > > > > Fixes: 078259773da9 ("net/i40e: store ethertype filter") > > Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter") > > Fixes: c50474f31efe ("net/i40e: support tunnel filter to VF") > > Fixes: 5c53c82c8174 ("net/i40e: store flow director filter") > > > > Signed-off-by: Yong Wang >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel, with commit log changes. Thanks! /Helin