From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8FEA31041; Fri, 2 Feb 2018 13:09:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Feb 2018 04:09:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,448,1511856000"; d="scan'208";a="200823694" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 02 Feb 2018 04:09:30 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Feb 2018 04:09:29 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Feb 2018 04:09:29 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.130]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Fri, 2 Feb 2018 20:09:28 +0800 From: "Zhang, Helin" To: "Xing, Beilei" , "Li, Xiaoyun" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix VF testpmd startup failure issue Thread-Index: AQHTm+nxEjb/32Mk2kCjg2TzFtx0SaOQ7TaAgAAYLPA= Date: Fri, 2 Feb 2018 12:09:27 +0000 Message-ID: References: <1517550316-175090-1-git-send-email-xiaoyun.li@intel.com> <94479800C636CB44BD422CB454846E01320C08D5@SHSMSX151.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E01320C08D5@SHSMSX151.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VF testpmd startup failure issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 12:09:33 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > Sent: Friday, February 2, 2018 6:44 PM > To: Li, Xiaoyun > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VF testpmd startup failure = issue >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Friday, February 2, 2018 1:45 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Li, Xiaoyun ; stable@dpdk.org > > Subject: [PATCH] net/i40e: fix VF testpmd startup failure issue > > > > New testpmd will get CRC strip offload from rx_offload_capa. I40evf > > cannot disable CRC strip. And in fact, it is enabled by PF. This patch > > solves the issue by adding CRC strip flag into rx_offload_capa in i40e = and > i40evf. > > > > Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by > > default") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li > > --- > > drivers/net/i40e/i40e_ethdev.c | 3 ++- > > drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 7e3d1a8..403831d 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -3083,7 +3083,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, > > struct rte_eth_dev_info *dev_info) > > DEV_RX_OFFLOAD_QINQ_STRIP | > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > DEV_RX_OFFLOAD_UDP_CKSUM | > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > + DEV_RX_OFFLOAD_CRC_STRIP; > > dev_info->tx_offload_capa =3D > > DEV_TX_OFFLOAD_VLAN_INSERT | > > DEV_TX_OFFLOAD_QINQ_INSERT | > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index 57f7613..169e1b1 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -2194,7 +2194,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, > > struct rte_eth_dev_info *dev_info) > > DEV_RX_OFFLOAD_QINQ_STRIP | > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > DEV_RX_OFFLOAD_UDP_CKSUM | > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > + DEV_RX_OFFLOAD_CRC_STRIP; > > dev_info->tx_offload_capa =3D > > DEV_TX_OFFLOAD_VLAN_INSERT | > > DEV_TX_OFFLOAD_QINQ_INSERT | > > -- > > 2.7.4 >=20 > Acked-by: Beilei Xing , thanks. Applied to dpdk-next-net-intel, with minor commit log changes. Thanks! /Helin