[dpdk-dev] [PATCH] net/ixgbe: fix CRC strip enabling

[dpdk-dev] [PATCH] net/ixgbe: fix CRC strip enabling

[Xiaoyun Li]

New testpmd will get CRC strip offload from rx_offload_capa. Ixgbe card
has the capability. This patch adds CRC strip flag into rx_offload_capa
in ixgbe and ixgbevf.

Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default")
Cc: stable@dpdk.org

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index c423cf2..4483258 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3651,7 +3651,8 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_VLAN_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM  |
-		DEV_RX_OFFLOAD_TCP_CKSUM;
+		DEV_RX_OFFLOAD_TCP_CKSUM  |
+		DEV_RX_OFFLOAD_CRC_STRIP;
 
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
@@ -3798,7 +3799,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
 	dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
 				DEV_RX_OFFLOAD_IPV4_CKSUM |
 				DEV_RX_OFFLOAD_UDP_CKSUM  |
-				DEV_RX_OFFLOAD_TCP_CKSUM;
+				DEV_RX_OFFLOAD_TCP_CKSUM  |
+				DEV_RX_OFFLOAD_CRC_STRIP;
 	dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |
 				DEV_TX_OFFLOAD_IPV4_CKSUM  |
 				DEV_TX_OFFLOAD_UDP_CKSUM   |
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/ixgbe: fix CRC strip enabling

[Lu, Wenzhuo]

Hi,

> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, February 8, 2018 1:45 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix CRC strip enabling
> 
> New testpmd will get CRC strip offload from rx_offload_capa. Ixgbe card has
> the capability. This patch adds CRC strip flag into rx_offload_capa in ixgbe
> and ixgbevf.
> 
> Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Re: [dpdk-dev] [PATCH] net/ixgbe: fix CRC strip enabling

[Zhang, Helin]

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Thursday, February 8, 2018 2:08 PM
> To: Li, Xiaoyun
> Cc: dev@dpdk.org; Zhang, Helin; stable@dpdk.org
> Subject: RE: [PATCH] net/ixgbe: fix CRC strip enabling
> 
> Hi,
> 
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Thursday, February 8, 2018 1:45 PM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Cc: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Li, Xiaoyun
> > <xiaoyun.li@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ixgbe: fix CRC strip enabling
> >
> > New testpmd will get CRC strip offload from rx_offload_capa. Ixgbe
> > card has the capability. This patch adds CRC strip flag into
> > rx_offload_capa in ixgbe and ixgbevf.
> >
> > Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by
> > default")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-dpdk-intel, with commit log changes. Thanks!

/Helin