From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A2C8F1B7D6 for ; Thu, 8 Feb 2018 14:44:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 05:44:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="18282463" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 08 Feb 2018 05:44:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 05:44:44 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 21:44:42 +0800 From: "Zhang, Helin" To: "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg Thread-Index: AQHToN804u3bBJC340q+5054HP7zAaOago+wgAABjFA= Date: Thu, 8 Feb 2018 13:44:42 +0000 Message-ID: References: <1518095892-61961-1-git-send-email-beilei.xing@intel.com> <9BB6961774997848B5B42BEC655768F810F71318@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810F71318@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 13:44:46 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Thursday, February 8, 2018 9:39 PM > To: Xing, Beilei; dev@dpdk.org; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse d= evarg >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Thursday, February 8, 2018 9:18 PM > > To: Wu, Jingjing ; dev@dpdk.org; Zhang, Qi Z > > > > Subject: [PATCH] net/i40e: fix unchecked return in parse devarg > > > > This patch fixes the coverity CHECKED_RETURN issue. > > > > Coverity issue: 261779 > > Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") > > > > Reported-by: John McNamara > > Signed-off-by: Beilei Xing > > --- > > drivers/net/i40e/i40e_ethdev.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 65a4b7a..508b417 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1107,8 +1107,12 @@ i40e_support_multi_driver(struct rte_eth_dev > *dev) > > "the first invalid or last valid one is used !", > > ETH_I40E_SUPPORT_MULTI_DRIVER); > > > > - rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER, > > - i40e_parse_multi_drv_handler, pf); > > + if (rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER, > > + i40e_parse_multi_drv_handler, pf) < 0) { > > + rte_kvargs_free(kvlist); > > + return -EINVAL; > > + } > > + > > rte_kvargs_free(kvlist); > > return 0; > > } > > -- > > 2.5.5 > Acked-by: Jingjing Wu Applied to dpdk-next-net-intel. Thanks! /Helin