From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C55AA4C9D for ; Fri, 9 Mar 2018 14:22:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 05:22:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,445,1515484800"; d="scan'208";a="23189836" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 09 Mar 2018 05:22:31 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Mar 2018 05:22:31 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Mar 2018 05:22:30 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Fri, 9 Mar 2018 21:22:29 +0800 From: "Zhang, Helin" To: "Lu, Wenzhuo" , "Zhang, Roy Fan" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait Thread-Index: AQHTttgHC/S+Ir+7+k+rlAgdjdUjgKPHEh8AgADNCdA= Date: Fri, 9 Mar 2018 13:22:28 +0000 Message-ID: References: <20180308115524.70244-1-roy.fan.zhang@intel.com> <20180308121752.70424-1-roy.fan.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B749EDA@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B749EDA@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 13:22:35 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, March 9, 2018 4:45 PM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: Glynn, Michael J; Zhang, Roy Fan; stable@dpdk.org; Zhang, Helin; Lian= g, > Cunming; Chilikin, Andrey > Subject: RE: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait >=20 > Hi, >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > Sent: Thursday, March 8, 2018 8:18 PM > > To: dev@dpdk.org > > Cc: Glynn, Michael J ; Zhang, Roy Fan > > ; stable@dpdk.org; Zhang, Helin > > ; Liang, Cunming ; > > Chilikin, Andrey > > Subject: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait > > > > Fixes: 263333bbb7a9 ("i40e: fix link status timeout") > > Cc: cunming.liang@intel.com > > Cc: stable@dpdk.org > > > > In i40e_dev_link_update() the driver obtains the link status info via > > admin queue command despite of "no_wait" flag. This requires > > relatively long time and may be a problem to some application such as > > ovs-dpdk (https://bugzilla.redhat.com/show_bug.cgi?id=3D1551761). > > > > This patch aims to fix the problem by using a different approach of > > obtaining link status for i40e NIC without waiting. > > Instead of getting the link status via admin queue command, this patch > > reads the link status registers to accelerate the procedure. > > > > Signed-off-by: Fan Zhang > > Signed-off-by: Andrey Chilikin > Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel, with minor commit log changes. Thanks! /Helin