[dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

[dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

[Kirill Rybalchenko]

Group ID 0xFF indicates that packages does not change parser
graph so compatible with any other packages.

Fixes: b1ec717bfff5 ("net/i40e: fix multiple DDP packages conflict")

Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
 drivers/net/i40e/rte_pmd_i40e.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index dae59e6..ada3eff 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -1530,6 +1530,11 @@ i40e_check_profile_info(uint16_t port, uint8_t *profile_info_sec)
 			return 1;
 		}
 	}
+	/* profile with group id 0xff is compatible with any other profile */
+	if ((pinfo->track_id & group_mask) == group_mask) {
+		rte_free(buff);
+		return 0;
+	}
 	for (i = 0; i < p_list->p_count; i++) {
 		p = &p_list->p_info[i];
 		if ((p->track_id & group_mask) == 0) {
@@ -1540,6 +1545,8 @@ i40e_check_profile_info(uint16_t port, uint8_t *profile_info_sec)
 	}
 	for (i = 0; i < p_list->p_count; i++) {
 		p = &p_list->p_info[i];
+		if ((p->track_id & group_mask) == group_mask)
+			continue;
 		if ((pinfo->track_id & group_mask) !=
 		    (p->track_id & group_mask)) {
 			PMD_DRV_LOG(INFO, "Profile of different group exists.");
-- 
2.5.5

Re: [dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

[Zhang, Qi Z]

> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Friday, February 23, 2018 2:02 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Rybalchenko, Kirill <kirill.rybalchenko@intel.com>;
> Chilikin, Andrey <andrey.chilikin@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix support DDP packages group 0xff
> 
> Group ID 0xFF indicates that packages does not change parser graph so
> compatible with any other packages.
> 
> Fixes: b1ec717bfff5 ("net/i40e: fix multiple DDP packages conflict")
> 
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Re: [dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

[Zhang, Helin]

> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, March 28, 2018 2:25 PM
> To: Rybalchenko, Kirill; dev@dpdk.org
> Cc: stable@dpdk.org; Chilikin, Andrey; Xing, Beilei; Zhang, Helin
> Subject: RE: [PATCH] net/i40e: fix support DDP packages group 0xff
> 
> 
> 
> > -----Original Message-----
> > From: Rybalchenko, Kirill
> > Sent: Friday, February 23, 2018 2:02 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Rybalchenko, Kirill
> > <kirill.rybalchenko@intel.com>; Chilikin, Andrey
> > <andrey.chilikin@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>
> > Subject: [PATCH] net/i40e: fix support DDP packages group 0xff
> >
> > Group ID 0xFF indicates that packages does not change parser graph so
> > compatible with any other packages.
> >
> > Fixes: b1ec717bfff5 ("net/i40e: fix multiple DDP packages conflict")
> >
> > Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin