* [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration
@ 2018-02-11 7:09 Beilei Xing
2018-03-14 15:16 ` Rybalchenko, Kirill
2018-03-29 6:33 ` [dpdk-dev] [PATCH v2] " Beilei Xing
0 siblings, 2 replies; 5+ messages in thread
From: Beilei Xing @ 2018-02-11 7:09 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev
Remove unnecessary FDIR mask configuration, otherwise
flow directory mask will be changed when configuring
hash input set.
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/rte_pmd_i40e.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index 1288c51..b684249 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t pctype,
return -ENOTSUP;
}
- /* Clear mask first */
- for (i = 0; i < 2; i++)
- i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), 0);
-
inset_reg = inset->inset;
for (i = 0; i < 2; i++)
mask_reg[i] = (inset->mask[i].field_idx << 16) |
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration
2018-02-11 7:09 [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration Beilei Xing
@ 2018-03-14 15:16 ` Rybalchenko, Kirill
2018-03-26 3:15 ` Zhang, Qi Z
2018-03-29 6:33 ` [dpdk-dev] [PATCH v2] " Beilei Xing
1 sibling, 1 reply; 5+ messages in thread
From: Rybalchenko, Kirill @ 2018-03-14 15:16 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Qi Z; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Sunday 11 February 2018 07:10
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> configuration
>
> Remove unnecessary FDIR mask configuration, otherwise flow directory
> mask will be changed when configuring hash input set.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/i40e/rte_pmd_i40e.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.c
> +++ b/drivers/net/i40e/rte_pmd_i40e.c
> @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t
> pctype,
> return -ENOTSUP;
> }
>
> - /* Clear mask first */
> - for (i = 0; i < 2; i++)
> - i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype),
> 0);
> -
> inset_reg = inset->inset;
> for (i = 0; i < 2; i++)
> mask_reg[i] = (inset->mask[i].field_idx << 16) |
> --
> 2.5.5
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration
2018-03-14 15:16 ` Rybalchenko, Kirill
@ 2018-03-26 3:15 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2018-03-26 3:15 UTC (permalink / raw)
To: Rybalchenko, Kirill, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Wednesday, March 14, 2018 11:17 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> configuration
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > Sent: Sunday 11 February 2018 07:10
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> > configuration
> >
> > Remove unnecessary FDIR mask configuration, otherwise flow directory
> > mask will be changed when configuring hash input set.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> > drivers/net/i40e/rte_pmd_i40e.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> > b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.c
> > +++ b/drivers/net/i40e/rte_pmd_i40e.c
> > @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t
> > pctype,
> > return -ENOTSUP;
> > }
> >
> > - /* Clear mask first */
> > - for (i = 0; i < 2; i++)
> > - i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype),
> > 0);
> > -
> > inset_reg = inset->inset;
> > for (i = 0; i < 2; i++)
> > mask_reg[i] = (inset->mask[i].field_idx << 16) |
> > --
> > 2.5.5
>
>
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>
>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: remove unnecessary FDIR mask configuration
2018-02-11 7:09 [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration Beilei Xing
2018-03-14 15:16 ` Rybalchenko, Kirill
@ 2018-03-29 6:33 ` Beilei Xing
2018-03-30 3:04 ` Zhang, Helin
1 sibling, 1 reply; 5+ messages in thread
From: Beilei Xing @ 2018-03-29 6:33 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev
Remove unnecessary FDIR mask configuration, otherwise
flow directory mask will be changed when configuring
hash input set.
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
v2 change:
- Rebase code base.
drivers/net/i40e/rte_pmd_i40e.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index 5a837d7..9f9a650 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -3103,10 +3103,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t pctype,
return -ENOTSUP;
}
- /* Clear mask first */
- for (i = 0; i < 2; i++)
- i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), 0);
-
inset_reg = inset->inset;
for (i = 0; i < 2; i++)
mask_reg[i] = (inset->mask[i].field_idx << 16) |
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: remove unnecessary FDIR mask configuration
2018-03-29 6:33 ` [dpdk-dev] [PATCH v2] " Beilei Xing
@ 2018-03-30 3:04 ` Zhang, Helin
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Helin @ 2018-03-30 3:04 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Qi Z; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Thursday, March 29, 2018 2:34 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/i40e: remove unnecessary FDIR mask
> configuration
>
> Remove unnecessary FDIR mask configuration, otherwise flow directory mask
> will be changed when configuring hash input set.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-30 3:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-11 7:09 [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration Beilei Xing
2018-03-14 15:16 ` Rybalchenko, Kirill
2018-03-26 3:15 ` Zhang, Qi Z
2018-03-29 6:33 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2018-03-30 3:04 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).