From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CD7F61CE76 for ; Fri, 6 Apr 2018 11:15:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2018 02:15:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,414,1517904000"; d="scan'208";a="214399905" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2018 02:15:35 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Apr 2018 02:15:34 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Apr 2018 02:15:34 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by shsmsx102.ccr.corp.intel.com ([169.254.2.61]) with mapi id 14.03.0319.002; Fri, 6 Apr 2018 17:15:30 +0800 From: "Zhang, Helin" To: "Zhao1, Wei" , Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" CC: "Lu, Wenzhuo" , Chas Williams Thread-Topic: [dpdk-dev] [PATCH] net/e1000: add mac_addr_set set to em Thread-Index: AQHTqRo7dvRjlTB4gUiWFCDG8K81z6PtQGgQgAZs9uA= Date: Fri, 6 Apr 2018 08:30:33 +0000 Message-ID: References: <20180219003955.18775-1-3chas3@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: add mac_addr_set set to em X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 09:15:36 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Monday, April 2, 2018 2:17 PM > To: Chas Williams; dev@dpdk.org > Cc: Lu, Wenzhuo; Chas Williams > Subject: Re: [dpdk-dev] [PATCH] net/e1000: add mac_addr_set set to em >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams > > Sent: Monday, February 19, 2018 8:40 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Chas Williams > > Subject: [dpdk-dev] [PATCH] net/e1000: add mac_addr_set set to em > > > > From: Chas Williams > > > > Based on the equivalent code in the igb driver. > > > > Signed-off-by: Chas Williams > > --- > > drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/net/e1000/em_ethdev.c > > b/drivers/net/e1000/em_ethdev.c index 242375f..5bb9cc9 100644 > > --- a/drivers/net/e1000/em_ethdev.c > > +++ b/drivers/net/e1000/em_ethdev.c > > @@ -94,6 +94,8 @@ static int em_get_rx_buffer_size(struct e1000_hw > > *hw); static int eth_em_rar_set(struct rte_eth_dev *dev, struct > > ether_addr *mac_addr, > > uint32_t index, uint32_t pool); > > static void eth_em_rar_clear(struct rte_eth_dev *dev, uint32_t > > index); > > +static void eth_em_default_mac_addr_set(struct rte_eth_dev *dev, > > + struct ether_addr *addr); > > > > static int eth_em_set_mc_addr_list(struct rte_eth_dev *dev, > > struct ether_addr *mc_addr_set, @@ -190,6 > +192,7 @@ static > > const struct eth_dev_ops eth_em_ops =3D { > > .dev_led_off =3D eth_em_led_off, > > .flow_ctrl_get =3D eth_em_flow_ctrl_get, > > .flow_ctrl_set =3D eth_em_flow_ctrl_set, > > + .mac_addr_set =3D eth_em_default_mac_addr_set, > > .mac_addr_add =3D eth_em_rar_set, > > .mac_addr_remove =3D eth_em_rar_clear, > > .set_mc_addr_list =3D eth_em_set_mc_addr_list, > > @@ -1809,6 +1812,15 @@ eth_em_rar_clear(struct rte_eth_dev *dev, > > uint32_t index) > > e1000_rar_set(hw, addr, index); > > } > > > > +static void > > +eth_em_default_mac_addr_set(struct rte_eth_dev *dev, > > + struct ether_addr *addr) > > +{ > > + eth_em_rar_clear(dev, 0); > > + > > + eth_em_rar_set(dev, (void *)addr, 0, 0); } > > + > > static int > > eth_em_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > -- > > 2.9.5 >=20 >=20 > I think this patch is need by em to enable the feature of configuration = for > default Receive Address Register, if DPDK user use rte function of > rte_eth_dev_default_mac_addr_set(), it can do this config work like othe= r NIC. >=20 > Acked-by: Wei Zhao Applied to dpdk-next-net-intel, thanks! /Helin