From: "Zhang, Helin" <helin.zhang@intel.com>
To: Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Charles (Chas) Williams" <chas3@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()
Date: Fri, 6 Apr 2018 15:09:05 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AE15AF3@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180201223907.31240-1-3chas3@gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams
> Sent: Friday, February 2, 2018 6:39 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()
>
> From: "Charles (Chas) Williams" <chas3@att.com>
>
> If we haven't set wait_to_complete, there is no need to busy wait until we
> have a link status. Applications, like bonding, use the wait_to_complete flag to
> indicate that they will be doing their own busy wait and will likely be polling
> again shortly.
>
> Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
>
> Signed-off-by: Chas Williams <chas3@att.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
BTW, the title should be corrected by following the format rule of patches on
DPDK community. Basically it shouldn't mention the function name in the title.
next prev parent reply other threads:[~2018-04-06 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 22:39 Chas Williams
2018-04-06 15:09 ` Zhang, Helin [this message]
2018-04-06 15:16 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AE15AF3@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).