From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F127C1D23E for ; Fri, 6 Apr 2018 17:09:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2018 08:09:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,415,1517904000"; d="scan'208";a="39889017" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 06 Apr 2018 08:09:08 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Apr 2018 08:09:07 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.163]) with mapi id 14.03.0319.002; Fri, 6 Apr 2018 23:09:05 +0800 From: "Zhang, Helin" To: Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Charles (Chas) Williams" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link() Thread-Index: AQHTm62MGrQVAn9ZokGZwntfrKyr76P0Od3w Date: Fri, 6 Apr 2018 15:09:05 +0000 Message-ID: References: <20180201223907.31240-1-3chas3@gmail.com> In-Reply-To: <20180201223907.31240-1-3chas3@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 15:09:09 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams > Sent: Friday, February 2, 2018 6:39 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_lin= k() >=20 > From: "Charles (Chas) Williams" >=20 > If we haven't set wait_to_complete, there is no need to busy wait until w= e > have a link status. Applications, like bonding, use the wait_to_complete= flag to > indicate that they will be doing their own busy wait and will likely be p= olling > again shortly. >=20 > Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") >=20 > Signed-off-by: Chas Williams Acked-by: Helin Zhang BTW, the title should be corrected by following the format rule of patches = on DPDK community. Basically it shouldn't mention the function name in the tit= le.