From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1FA872C6A for ; Tue, 8 May 2018 03:47:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 18:47:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,376,1520924400"; d="scan'208";a="49054972" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 07 May 2018 18:47:40 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 18:47:40 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 18:47:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Tue, 8 May 2018 09:47:38 +0800 From: "Zhang, Helin" To: "Xu, Rosen" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Wu, Jingjing" Thread-Topic: [PATCH v5] net/i40e: fix disabling promiscuous mode Thread-Index: AQHT3uVSu/S1hKzuZ0WMtJvSG5AQCqQlHahw Date: Tue, 8 May 2018 01:47:38 +0000 Message-ID: References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com> <1524915533-96768-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1524915533-96768-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: fix disabling promiscuous mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 01:47:42 -0000 > -----Original Message----- > From: Xu, Rosen > Sent: Saturday, April 28, 2018 7:39 PM > To: dev@dpdk.org > Cc: Zhang, Helin; Zhang, Qi Z; Wu, Jingjing; stable@dpdk.org > Subject: [PATCH v5] net/i40e: fix disabling promiscuous mode >=20 > v5 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Modificate some comments for this patch >=20 > v4 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Add some comments for this patch >=20 > v3 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Move modification from device close to device disable > - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous= , > so unicast/multicast promiscuous disable should set before reset. >=20 > v2 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Add more comments >=20 > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit does= n't > disable promiscuous mode, this will cause vlan filter set by Kernel Drive= r will > not take effect. >=20 > This patch will fix it, add promiscuous disable at device disable. >=20 > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rosen Xu > Acked-by: Qi Zhang Applied to dpdk-next-net-intel, thanks! Helin