Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

[Zhang, Qi Z]

> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, May 16, 2018 12:19 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix fail to disable FDIR Tx queue
> 
> If flow directory is enabled, FDIR Tx queue can't be disabled when exiting
> application. Root cause is FDIR Tx queue is not disabled before removing HMC
> backing store.
> 
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

[dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

[Beilei Xing]

If flow directory is enabled, FDIR Tx queue can't
be disabled when exiting application. Root cause
is FDIR Tx queue is not disabled before removing
HMC backing store.

Fixes: 71d35259ff67 ("i40e: tear down flow director")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 894505f..7313753 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2340,6 +2340,8 @@ i40e_dev_close(struct rte_eth_dev *dev)
 	i40e_pf_disable_irq0(hw);
 	rte_intr_disable(intr_handle);
 
+	i40e_fdir_teardown(pf);
+
 	/* shutdown and destroy the HMC */
 	i40e_shutdown_lan_hmc(hw);
 
@@ -2351,7 +2353,6 @@ i40e_dev_close(struct rte_eth_dev *dev)
 	pf->vmdq = NULL;
 
 	/* release all the existing VSIs and VEBs */
-	i40e_fdir_teardown(pf);
 	i40e_vsi_release(pf->main_vsi);
 
 	/* shutdown the adminq */
-- 
2.5.5

Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Tuesday, May 15, 2018 8:36 PM
> To: Xing, Beilei; Wu, Jingjing
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue
> 
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Wednesday, May 16, 2018 12:19 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH] net/i40e: fix fail to disable FDIR Tx queue
> >
> > If flow directory is enabled, FDIR Tx queue can't be disabled when
> > exiting application. Root cause is FDIR Tx queue is not disabled
> > before removing HMC backing store.
> >
> > Fixes: 71d35259ff67 ("i40e: tear down flow director")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin