* Re: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
2018-05-17 13:22 [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue Qiming Yang
@ 2018-05-17 13:18 ` Zhang, Qi Z
2018-05-18 1:26 ` Yang, Qiming
2018-05-18 4:25 ` Wu, Jingjing
2018-05-18 9:51 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2 siblings, 1 reply; 7+ messages in thread
From: Zhang, Qi Z @ 2018-05-17 13:18 UTC (permalink / raw)
To: dev; +Cc: Wu, Jingjing, Lu, Wenzhuo, Yang, Qiming, stable
Hi Qiming
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org]
> Sent: Thursday, May 17, 2018 9:23 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
>
> This patch removed unnecessary check in ixgbe_check_mq_mode, fixed
> historical issue.
>
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 37 -------------------------------------
> 1 file changed, 37 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f5006bc..9e3ae95 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2300,43 +2300,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
> }
> }
>
> - /* For DCB mode check our configuration before we go further */
> - if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
> - const struct rte_eth_dcb_rx_conf *conf;
> -
> - if (nb_rx_q != IXGBE_DCB_NB_QUEUES) {
> - PMD_INIT_LOG(ERR, "DCB selected, nb_rx_q != %d.",
> - IXGBE_DCB_NB_QUEUES);
> - return -EINVAL;
> - }
> - conf = &dev_conf->rx_adv_conf.dcb_rx_conf;
> - if (!(conf->nb_tcs == ETH_4_TCS ||
> - conf->nb_tcs == ETH_8_TCS)) {
I guess, we should not remove all check, for nb_tcs, it still valid, right?
> - PMD_INIT_LOG(ERR, "DCB selected, nb_tcs != %d"
> - " and nb_tcs != %d.",
> - ETH_4_TCS, ETH_8_TCS);
> - return -EINVAL;
> - }
> - }
> -
> - if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
> - const struct rte_eth_dcb_tx_conf *conf;
> -
> - if (nb_tx_q != IXGBE_DCB_NB_QUEUES) {
> - PMD_INIT_LOG(ERR, "DCB, nb_tx_q != %d.",
> - IXGBE_DCB_NB_QUEUES);
> - return -EINVAL;
> - }
> - conf = &dev_conf->tx_adv_conf.dcb_tx_conf;
> - if (!(conf->nb_tcs == ETH_4_TCS ||
> - conf->nb_tcs == ETH_8_TCS)) {
Same to rx.
> - PMD_INIT_LOG(ERR, "DCB selected, nb_tcs != %d"
> - " and nb_tcs != %d.",
> - ETH_4_TCS, ETH_8_TCS);
> - return -EINVAL;
> - }
> - }
> -
> /*
> * When DCB/VT is off, maximum number of queues changes,
> * except for 82598EB, which remains constant.
> --
> 2.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
@ 2018-05-17 13:22 Qiming Yang
2018-05-17 13:18 ` Zhang, Qi Z
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Qiming Yang @ 2018-05-17 13:22 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, wenzhuo.lu, Qiming Yang, stable
This patch removed unnecessary check in ixgbe_check_mq_mode,
fixed historical issue.
Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 37 -------------------------------------
1 file changed, 37 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f5006bc..9e3ae95 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2300,43 +2300,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
}
}
- /* For DCB mode check our configuration before we go further */
- if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
- const struct rte_eth_dcb_rx_conf *conf;
-
- if (nb_rx_q != IXGBE_DCB_NB_QUEUES) {
- PMD_INIT_LOG(ERR, "DCB selected, nb_rx_q != %d.",
- IXGBE_DCB_NB_QUEUES);
- return -EINVAL;
- }
- conf = &dev_conf->rx_adv_conf.dcb_rx_conf;
- if (!(conf->nb_tcs == ETH_4_TCS ||
- conf->nb_tcs == ETH_8_TCS)) {
- PMD_INIT_LOG(ERR, "DCB selected, nb_tcs != %d"
- " and nb_tcs != %d.",
- ETH_4_TCS, ETH_8_TCS);
- return -EINVAL;
- }
- }
-
- if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
- const struct rte_eth_dcb_tx_conf *conf;
-
- if (nb_tx_q != IXGBE_DCB_NB_QUEUES) {
- PMD_INIT_LOG(ERR, "DCB, nb_tx_q != %d.",
- IXGBE_DCB_NB_QUEUES);
- return -EINVAL;
- }
- conf = &dev_conf->tx_adv_conf.dcb_tx_conf;
- if (!(conf->nb_tcs == ETH_4_TCS ||
- conf->nb_tcs == ETH_8_TCS)) {
- PMD_INIT_LOG(ERR, "DCB selected, nb_tcs != %d"
- " and nb_tcs != %d.",
- ETH_4_TCS, ETH_8_TCS);
- return -EINVAL;
- }
- }
-
/*
* When DCB/VT is off, maximum number of queues changes,
* except for 82598EB, which remains constant.
--
2.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
2018-05-17 13:18 ` Zhang, Qi Z
@ 2018-05-18 1:26 ` Yang, Qiming
0 siblings, 0 replies; 7+ messages in thread
From: Yang, Qiming @ 2018-05-18 1:26 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: Wu, Jingjing, Lu, Wenzhuo, stable
I'll send v2 later.
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, May 17, 2018 9:19 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
>
> Hi Qiming
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org]
> > Sent: Thursday, May 17, 2018 9:23 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
> >
> > This patch removed unnecessary check in ixgbe_check_mq_mode, fixed
> > historical issue.
> >
> > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to
> > specific
> > drivers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 37
> > -------------------------------------
> > 1 file changed, 37 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f5006bc..9e3ae95 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2300,43 +2300,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
> > }
> > }
> >
> > - /* For DCB mode check our configuration before we go further
> */
> > - if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
> > - const struct rte_eth_dcb_rx_conf *conf;
> > -
> > - if (nb_rx_q != IXGBE_DCB_NB_QUEUES) {
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_rx_q != %d.",
> > - IXGBE_DCB_NB_QUEUES);
> > - return -EINVAL;
> > - }
> > - conf = &dev_conf->rx_adv_conf.dcb_rx_conf;
> > - if (!(conf->nb_tcs == ETH_4_TCS ||
> > - conf->nb_tcs == ETH_8_TCS)) {
>
> I guess, we should not remove all check, for nb_tcs, it still valid, right?
>
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_tcs != %d"
> > - " and nb_tcs != %d.",
> > - ETH_4_TCS, ETH_8_TCS);
> > - return -EINVAL;
> > - }
> > - }
> > -
> > - if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
> > - const struct rte_eth_dcb_tx_conf *conf;
> > -
> > - if (nb_tx_q != IXGBE_DCB_NB_QUEUES) {
> > - PMD_INIT_LOG(ERR, "DCB, nb_tx_q != %d.",
> > - IXGBE_DCB_NB_QUEUES);
> > - return -EINVAL;
> > - }
> > - conf = &dev_conf->tx_adv_conf.dcb_tx_conf;
> > - if (!(conf->nb_tcs == ETH_4_TCS ||
> > - conf->nb_tcs == ETH_8_TCS)) {
> Same to rx.
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_tcs != %d"
> > - " and nb_tcs != %d.",
> > - ETH_4_TCS, ETH_8_TCS);
> > - return -EINVAL;
> > - }
> > - }
> > -
> > /*
> > * When DCB/VT is off, maximum number of queues changes,
> > * except for 82598EB, which remains constant.
> > --
> > 2.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
2018-05-18 9:51 ` [dpdk-dev] [PATCH v2] " Qiming Yang
@ 2018-05-18 3:16 ` Lu, Wenzhuo
2018-05-18 14:33 ` Zhang, Helin
0 siblings, 1 reply; 7+ messages in thread
From: Lu, Wenzhuo @ 2018-05-18 3:16 UTC (permalink / raw)
To: dev, dev; +Cc: Zhang, Qi Z, Yang, Qiming, stable
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org]
> Sent: Friday, May 18, 2018 5:52 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
>
> This patch removed unnecessary check in ixgbe_check_mq_mode, fixed
> historical issue.
>
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
2018-05-17 13:22 [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue Qiming Yang
2018-05-17 13:18 ` Zhang, Qi Z
@ 2018-05-18 4:25 ` Wu, Jingjing
2018-05-18 9:51 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2 siblings, 0 replies; 7+ messages in thread
From: Wu, Jingjing @ 2018-05-18 4:25 UTC (permalink / raw)
To: Yang, Qiming, dev; +Cc: Lu, Wenzhuo, stable
> -----Original Message-----
> From: Yang, Qiming
> Sent: Thursday, May 17, 2018 9:23 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix dcb configuration issue
>
> This patch removed unnecessary check in ixgbe_check_mq_mode,
> fixed historical issue.
>
Hi, Qiming
Sorry, I didn't understand why the check is unnecessary, amd what is the historical issue?
Could you add a bit more comments here?
Thanks
Jingjing
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
2018-05-17 13:22 [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue Qiming Yang
2018-05-17 13:18 ` Zhang, Qi Z
2018-05-18 4:25 ` Wu, Jingjing
@ 2018-05-18 9:51 ` Qiming Yang
2018-05-18 3:16 ` Lu, Wenzhuo
2 siblings, 1 reply; 7+ messages in thread
From: Qiming Yang @ 2018-05-18 9:51 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, Qiming Yang, stable
This patch removed unnecessary check in ixgbe_check_mq_mode,
fixed historical issue.
Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f5006bc..eb92893 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2304,11 +2304,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
const struct rte_eth_dcb_rx_conf *conf;
- if (nb_rx_q != IXGBE_DCB_NB_QUEUES) {
- PMD_INIT_LOG(ERR, "DCB selected, nb_rx_q != %d.",
- IXGBE_DCB_NB_QUEUES);
- return -EINVAL;
- }
conf = &dev_conf->rx_adv_conf.dcb_rx_conf;
if (!(conf->nb_tcs == ETH_4_TCS ||
conf->nb_tcs == ETH_8_TCS)) {
@@ -2322,11 +2317,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
const struct rte_eth_dcb_tx_conf *conf;
- if (nb_tx_q != IXGBE_DCB_NB_QUEUES) {
- PMD_INIT_LOG(ERR, "DCB, nb_tx_q != %d.",
- IXGBE_DCB_NB_QUEUES);
- return -EINVAL;
- }
conf = &dev_conf->tx_adv_conf.dcb_tx_conf;
if (!(conf->nb_tcs == ETH_4_TCS ||
conf->nb_tcs == ETH_8_TCS)) {
--
2.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
2018-05-18 3:16 ` Lu, Wenzhuo
@ 2018-05-18 14:33 ` Zhang, Helin
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Helin @ 2018-05-18 14:33 UTC (permalink / raw)
To: Lu, Wenzhuo, dev, dev; +Cc: Zhang, Qi Z, Yang, Qiming, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Friday, May 18, 2018 11:16 AM
> To: dev; dev@dpdk.org
> Cc: Zhang, Qi Z; Yang, Qiming; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
>
> Hi,
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org]
> > Sent: Friday, May 18, 2018 5:52 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
> >
> > This patch removed unnecessary check in ixgbe_check_mq_mode, fixed
> > historical issue.
> >
> > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to
> > specific
> > drivers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-18 14:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 13:22 [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue Qiming Yang
2018-05-17 13:18 ` Zhang, Qi Z
2018-05-18 1:26 ` Yang, Qiming
2018-05-18 4:25 ` Wu, Jingjing
2018-05-18 9:51 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2018-05-18 3:16 ` Lu, Wenzhuo
2018-05-18 14:33 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).