From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id CD672989F for ; Mon, 21 May 2018 03:17:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2018 18:17:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,425,1520924400"; d="scan'208";a="57555801" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 20 May 2018 18:17:06 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 20 May 2018 18:17:06 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 20 May 2018 18:17:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by shsmsx102.ccr.corp.intel.com ([169.254.2.79]) with mapi id 14.03.0319.002; Mon, 21 May 2018 09:17:04 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Horton, Remy" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Xing, Beilei" , "Wu, Jingjing" Thread-Topic: [PATCH v2] i40e: fix corruption of VF stats via port representor Thread-Index: AQHT7p5VgJ/71eNvgkeriDBU8Xx/yqQ1y92AgAOZqNA= Date: Mon, 21 May 2018 01:17:03 +0000 Message-ID: References: <20180518075948.3177-1-remy.horton@intel.com> <20180518114948.24564-1-remy.horton@intel.com> <039ED4275CED7440929022BC67E70611531B4B7C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611531B4B7C@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 01:17:08 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 19, 2018 10:18 AM > To: Horton, Remy; dev@dpdk.org > Cc: Yigit, Ferruh; Xing, Beilei; Zhang, Helin; Wu, Jingjing > Subject: RE: [PATCH v2] i40e: fix corruption of VF stats via port represe= ntor >=20 >=20 >=20 > > -----Original Message----- > > From: Horton, Remy > > Sent: Friday, May 18, 2018 7:50 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Zhang, Qi Z > > ; Xing, Beilei ; Zhang, > > Helin ; Wu, Jingjing > > Subject: [PATCH v2] i40e: fix corruption of VF stats via port > > representor > > > > The resetting of stats on a VF involves the setting of an offset that > > is subtracted from future calls, rather zeroing of counters. > > However doing a stats reset on the port representor was also adjusting > > the values forwarded to the VF, which had the effect of corrupting the > > VF's counters. The fix is for the port representor to maintain its own > > stats offset, so the port representor and VF maintain independently- > resettable counters. > > > > Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") > > > > Signed-off-by: Remy Horton >=20 > Title prefix should be "net/i40e", could be fix during apply >=20 > Acked-by: Qi Zhang Applied to dpdk-next-net-intel, thanks! /Helin