From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A7BA91C0B for ; Tue, 22 May 2018 04:03:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 19:03:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,428,1520924400"; d="scan'208";a="57297545" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 21 May 2018 19:03:52 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 19:03:52 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 19:03:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Tue, 22 May 2018 10:03:50 +0800 From: "Zhang, Helin" To: "Varghese, Vipin" , "Van Haaren, Harry" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/e1000 igb: fix compile issue with log register Thread-Index: AQHT8OaW2fAr/GA6Mk2l6rrv69SYgaQ5b+SAgAGQQFA= Date: Tue, 22 May 2018 02:03:50 +0000 Message-ID: References: <1526895101-146792-1-git-send-email-harry.van.haaren@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BA4@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BA4@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 02:03:54 -0000 > -----Original Message----- > From: Varghese, Vipin > Sent: Monday, May 21, 2018 6:10 PM > To: Van Haaren, Harry; dev@dpdk.org > Cc: Lu, Wenzhuo; Zhang, Helin > Subject: RE: [PATCH] net/e1000 igb: fix compile issue with log register >=20 >=20 > > -----Original Message----- > > From: Van Haaren, Harry > > Sent: Monday, May 21, 2018 3:02 PM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry ; Varghese, Vipin > > ; Lu, Wenzhuo ; Zhang, > > Helin > > Subject: [PATCH] net/e1000 igb: fix compile issue with log register > > > > This commit fixes a compilation error if EM_PMD is not defined, bug > > IGB_PMD is. The root cause of the issue was that log init variables > > are declared as extern in a header file, while the definition of the va= riables > was in e1000_ethdev.c. > > Hence, the definitions were not available if the e1000 PMD is disabled. > > > > To fix this, a new file is added e1000_logs.c, which matches the > > e1000_logs.h header. The log variables are always compiled in, but the > > PMD logs are only registered if a PMD is enabled in the configuration. > > Extra checks are added in order to avoid duplicate registering. > > > > Fixes: ed5bbb767c3e ("net/e1000: implement dynamic logging") > > > > Reported-by: Vipin Varghese > > Signed-off-by: Harry van Haaren > Acked-by: Vipin Varghese Applied to dpdk-next-net-intel, thanks! /Helin