From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D3EEC6841 for ; Mon, 31 Jul 2017 19:06:08 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 31 Jul 2017 10:06:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,304,1498546800"; d="scan'208";a="1157367830" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 31 Jul 2017 10:06:07 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 31 Jul 2017 10:06:07 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.214]) by fmsmsx123.amr.corp.intel.com ([169.254.7.80]) with mapi id 14.03.0319.002; Mon, 31 Jul 2017 10:06:07 -0700 From: "Wiles, Keith" To: alan somers CC: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] Fix bash path in shebangs Thread-Index: AQHTBxjSuhWmUiDIpkWyHB6k3yogm6JpbsIAgAUW4YCAAAMZAIAAD7EAgAANUYA= Date: Mon, 31 Jul 2017 17:06:06 +0000 Message-ID: References: <20170727204146.9574-1-asomers@gmail.com> <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> <20170731152216.GA33288@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.51.124] Content-Type: text/plain; charset="us-ascii" Content-ID: <46F85B2F8B8BFE48B266C152EBC3C632@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 17:06:09 -0000 > On Jul 31, 2017, at 11:18 AM, alan somers wrote: >=20 > On Mon, Jul 31, 2017 at 9:22 AM, Bruce Richardson > wrote: >> On Mon, Jul 31, 2017 at 09:11:11AM -0600, alan somers wrote: >>> On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson >>> wrote: >>>> On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: >>>>> From: Alan Somers >>>>>=20 >>>>> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >>>>>=20 >>>>> Signed-off-by: Alan Somers >>>>> --- >>>>> examples/performance-thread/l3fwd-thread/test.sh | 2 +- >>>>> usertools/dpdk-setup.sh | 2 +- >>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>=20 >>>>> diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examp= les/performance-thread/l3fwd-thread/test.sh >>>>> index b7718b622..eb1fe2dc2 100755 >>>>> --- a/examples/performance-thread/l3fwd-thread/test.sh >>>>> +++ b/examples/performance-thread/l3fwd-thread/test.sh >>>>> @@ -1,4 +1,4 @@ >>>>> -#!/bin/bash >>>>> +#!/usr/bin/env bash >>>>>=20 >>>>> case "$1" in >>>>>=20 >>>> This script doesn't look to be using any bash specific features to me, >>>> so a better fix might be to change it to use /bin/sh rather than >>>> requiring bash itself. [Needs testing, to check there isn't something >>>> bash-specific hidden away, obviously] >>>=20 >>> True. Unfortunately, I can't test it right now because I can't get >>> DPDK to build on either Linux or FreeBSD, and I'm out of time to debug >>> the build failures for now. Would you like me to resubmit the patch, >>> altered to use /bin/sh, without testing? >>>=20 >>>>=20 >> I'm not sure it's that important a change that we need to rush into >> doing so. >>=20 >> What difficulties are you having getting DPDK to build? Is it just >> platform setup issues? >=20 > On Linux, I fail for lack of numa.h. The docs say to install > libnuma-devel, but that package doesn't exist on my distro (Ubuntu > 16.04). On FreeBSD, I get this compile error > /usr/home/alans/freebsd/head/sys/vm/vm_phys.h:120:2: error: use of undecl= ared > identifier 'vm_cnt' > vm_cnt.v_free_count +=3D adj; On my Ubuntu 17.04 the package is called libnuma-dev=20 >=20 > On FreeBSD stable/11, I get a litany of errors, beginning with: > n file included from contigmem.c:49: > In file included from ./machine/bus.h:6: > In file included from ./x86/bus.h:1038: > In file included from ./machine/bus_dma.h:32: > ./x86/bus_dma.h:43:1: error: static declaration of 'bus_dmamap_create' fo= llows > non-static declaration > bus_dmamap_create(bus_dma_tag_t dmat, int flags, bus_dmamap_t *mapp) > ^ > /usr/home/alans/freebsd/stable_11/sys/sys/bus_dma.h:262:5: note: previous > declaration is here > int bus_dmamap_create(bus_dma_tag_t dmat, int flags, bus_dmamap_t *mapp); >=20 > And on FreeBSD stable/10, I get a make error: > make[6]: "/usr/home/alans/freebsd/stable_10/sys/conf/kern.mk" line 43: > Malformed conditional (${MK_FORMAT_EXTENSIONS} =3D=3D "no") >=20 > -Alan Regards, Keith