From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"pascal.mazon@6wind.com" <pascal.mazon@6wind.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined
Date: Tue, 15 May 2018 12:36:14 +0000 [thread overview]
Message-ID: <F4B0B619-1B57-4C85-A0B6-22E2D94C7E49@intel.com> (raw)
In-Reply-To: <1526106612-149893-1-git-send-email-vipin.varghese@intel.com>
> On May 12, 2018, at 1:30 AM, Vipin Varghese <vipin.varghese@intel.com> wrote:
>
> Updating the logic to reflect unsigned integer as index for TAP PMD.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 48c61b3..db397d6 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -64,7 +64,7 @@ static const char *valid_arguments[] = {
> NULL
> };
>
> -static int tap_unit;
> +static unsigned int tap_unit;
> static unsigned int tun_unit;
>
> static int tap_type;
> @@ -1735,7 +1735,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
> }
>
> speed = ETH_SPEED_NUM_10G;
> - snprintf(tap_name, sizeof(tap_name), "%s%d",
> + snprintf(tap_name, sizeof(tap_name), "%s%u",
> DEFAULT_TAP_NAME, tap_unit++);
> memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
>
> --
> 2.7.4
>
Acked by Keith Wiles<keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2018-05-15 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 6:30 Vipin Varghese
2018-05-15 12:36 ` Wiles, Keith [this message]
2018-05-31 16:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4B0B619-1B57-4C85-A0B6-22E2D94C7E49@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pascal.mazon@6wind.com \
--cc=stephen@networkplumber.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).