* [dpdk-dev] [PATCH] net/tap: update tap index to unsgined
@ 2018-05-12 6:30 Vipin Varghese
2018-05-15 12:36 ` Wiles, Keith
0 siblings, 1 reply; 3+ messages in thread
From: Vipin Varghese @ 2018-05-12 6:30 UTC (permalink / raw)
To: ferruh.yigit, pascal.mazon, stephen, dev; +Cc: Vipin Varghese
Updating the logic to reflect unsigned integer as index for TAP PMD.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
drivers/net/tap/rte_eth_tap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 48c61b3..db397d6 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -64,7 +64,7 @@ static const char *valid_arguments[] = {
NULL
};
-static int tap_unit;
+static unsigned int tap_unit;
static unsigned int tun_unit;
static int tap_type;
@@ -1735,7 +1735,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
}
speed = ETH_SPEED_NUM_10G;
- snprintf(tap_name, sizeof(tap_name), "%s%d",
+ snprintf(tap_name, sizeof(tap_name), "%s%u",
DEFAULT_TAP_NAME, tap_unit++);
memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined
2018-05-12 6:30 [dpdk-dev] [PATCH] net/tap: update tap index to unsgined Vipin Varghese
@ 2018-05-15 12:36 ` Wiles, Keith
2018-05-31 16:07 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wiles, Keith @ 2018-05-15 12:36 UTC (permalink / raw)
To: Varghese, Vipin; +Cc: Yigit, Ferruh, pascal.mazon, stephen, dev
> On May 12, 2018, at 1:30 AM, Vipin Varghese <vipin.varghese@intel.com> wrote:
>
> Updating the logic to reflect unsigned integer as index for TAP PMD.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 48c61b3..db397d6 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -64,7 +64,7 @@ static const char *valid_arguments[] = {
> NULL
> };
>
> -static int tap_unit;
> +static unsigned int tap_unit;
> static unsigned int tun_unit;
>
> static int tap_type;
> @@ -1735,7 +1735,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
> }
>
> speed = ETH_SPEED_NUM_10G;
> - snprintf(tap_name, sizeof(tap_name), "%s%d",
> + snprintf(tap_name, sizeof(tap_name), "%s%u",
> DEFAULT_TAP_NAME, tap_unit++);
> memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
>
> --
> 2.7.4
>
Acked by Keith Wiles<keith.wiles@intel.com>
Regards,
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined
2018-05-15 12:36 ` Wiles, Keith
@ 2018-05-31 16:07 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-31 16:07 UTC (permalink / raw)
To: Wiles, Keith, Varghese, Vipin; +Cc: pascal.mazon, stephen, dev
On 5/15/2018 1:36 PM, Wiles, Keith wrote:
>
>
>> On May 12, 2018, at 1:30 AM, Vipin Varghese <vipin.varghese@intel.com> wrote:
>>
>> Updating the logic to reflect unsigned integer as index for TAP PMD.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
<...>
> Acked by Keith Wiles<keith.wiles@intel.com>
Repeating ack with "-" to help patchwork:
Acked-by: Keith Wiles <keith.wiles@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-31 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-12 6:30 [dpdk-dev] [PATCH] net/tap: update tap index to unsgined Vipin Varghese
2018-05-15 12:36 ` Wiles, Keith
2018-05-31 16:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).