From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 29B301B8D5 for ; Tue, 15 May 2018 14:36:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2018 05:36:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,403,1520924400"; d="scan'208";a="228721869" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 15 May 2018 05:36:15 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.235]) by FMSMSX106.amr.corp.intel.com ([169.254.5.29]) with mapi id 14.03.0319.002; Tue, 15 May 2018 05:36:15 -0700 From: "Wiles, Keith" To: "Varghese, Vipin" CC: "Yigit, Ferruh" , "pascal.mazon@6wind.com" , "stephen@networkplumber.org" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined Thread-Index: AQHT6bq1qvaqj7/RokeaKRQFLhWGVqQxNIGA Date: Tue, 15 May 2018 12:36:14 +0000 Message-ID: References: <1526106612-149893-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1526106612-149893-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.205.129] Content-Type: text/plain; charset="us-ascii" Content-ID: <2C9B75FD44D4494093BE5480914D4186@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 12:36:16 -0000 > On May 12, 2018, at 1:30 AM, Vipin Varghese wr= ote: >=20 > Updating the logic to reflect unsigned integer as index for TAP PMD. >=20 > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 48c61b3..db397d6 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -64,7 +64,7 @@ static const char *valid_arguments[] =3D { > NULL > }; >=20 > -static int tap_unit; > +static unsigned int tap_unit; > static unsigned int tun_unit; >=20 > static int tap_type; > @@ -1735,7 +1735,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > } >=20 > speed =3D ETH_SPEED_NUM_10G; > - snprintf(tap_name, sizeof(tap_name), "%s%d", > + snprintf(tap_name, sizeof(tap_name), "%s%u", > DEFAULT_TAP_NAME, tap_unit++); > memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN); >=20 > --=20 > 2.7.4 >=20 Acked by Keith Wiles Regards, Keith