From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA74E590F for ; Tue, 20 May 2014 03:15:25 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 19 May 2014 18:10:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,870,1392192000"; d="scan'208";a="543212988" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by orsmga002.jf.intel.com with ESMTP; 19 May 2014 18:14:56 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.19.17.7) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 19 May 2014 18:14:56 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.19.17.7) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 19 May 2014 18:14:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.190]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.7]) with mapi id 14.03.0123.003; Tue, 20 May 2014 09:14:54 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition and fix wrong referring in user space vhost zero copy patches Thread-Index: AQHPc3RkrY/5mCabZEWVJYv0tj1eYJtHidCAgAEfHZA= Date: Tue, 20 May 2014 01:14:53 +0000 Message-ID: References: <1400512177-19315-1-git-send-email-changchun.ouyang@intel.com> <1478243.AGf3d0Vu1X@xps13> In-Reply-To: <1478243.AGf3d0Vu1X@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition and fix wrong referring in user space vhost zero copy patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2014 01:15:26 -0000 Hi Thomas, Fine, I will do it. One more question: You have comments as follow: The title was "[PATCH 0/3] [PMD] [VHOST] *** Support zero copy RX/TX in use= r space vhost ***" It should be "[PATCH v2 0/3] Support zero copy RX/TX in user space vhost" So "[PMD] [VHOST]" in the title should be removed in the cover letter, righ= t? And in each separate patch letter, it could use "ixgbe:" or "examples/vhos= t:", instead of "[PMD] [VHOST]" =20 Is it right? Thanks=20 Changchun -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Tuesday, May 20, 2014 12:00 AM To: Ouyang, Changchun Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition= and fix wrong referring in user space vhost zero copy patches Hi Changchun, 2014-05-19 23:09, Ouyang Changchun: > 1. Revert the change of metadata macro definition for referring to=20 > headroom space in mbuf; 2. Fix wrongly referring to RX queues number=20 > in TX queues start/stop function. >=20 > Signed-off-by: Ouyang Changchun You are fixing commits which are not yet applied. Please merge and re-send the whole serie by suffixing with "v2". The title was "[PATCH 0/3] [PMD] [VHOST] *** Support zero copy RX/TX in use= r space vhost ***" It should be "[PATCH v2 0/3] Support zero copy RX/TX in user space vhost" Other notes: - please split API and ixgbe changes - set a significant title to each patch - use prefixes like "ethdev:", "ixgbe:" or "examples/vhost:" In general, this page is a good help: http://dpdk.org/dev#send Thanks -- Thomas