From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4289230D for ; Thu, 5 Jun 2014 05:11:38 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 04 Jun 2014 20:11:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,977,1392192000"; d="scan'208";a="549996933" Received: from fmsmsx105.amr.corp.intel.com ([10.19.9.36]) by fmsmga002.fm.intel.com with ESMTP; 04 Jun 2014 20:11:49 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.19.9.29) by FMSMSX105.amr.corp.intel.com (10.19.9.36) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 4 Jun 2014 20:11:49 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.19.9.29) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 4 Jun 2014 20:11:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.190]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.37]) with mapi id 14.03.0123.003; Thu, 5 Jun 2014 11:11:47 +0800 From: "Ouyang, Changchun" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH v2 0/3] Support setting TX rate for queue and VF Thread-Index: AQHPeLaUyvnkT8GBCE+vBxAV8x4+TZtS8u+AgA7xNAA= Date: Thu, 5 Jun 2014 03:11:46 +0000 Message-ID: References: <1401090331-18455-1-git-send-email-changchun.ouyang@intel.com> <20140526225257.GB15911@neilslaptop.think-freely.org> In-Reply-To: <20140526225257.GB15911@neilslaptop.think-freely.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Support setting TX rate for queue and VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2014 03:11:39 -0000 Hi, Neil " but you're implementaiton requires that it be re-implemented for each PMD= " [Changchun]: Different PMD(corresponding diff NIC) has different register t= o set. It makes sense to me has different implementation to support limit tx rate. =20 " Why not just export max tx rates from the PMD and write a generic queuing= libarary to do rate limitation for any PMD?" [Changchun]: Just export max tx rate is not enough for customer. I think if we can leverage HW feature to do it, why need a more complicated= lib to do so?=20 Thanks Changchun -----Original Message----- From: Neil Horman [mailto:nhorman@tuxdriver.com]=20 Sent: Tuesday, May 27, 2014 6:53 AM To: Ouyang, Changchun Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/3] Support setting TX rate for queue an= d VF On Mon, May 26, 2014 at 03:45:28PM +0800, Ouyang Changchun wrote: > This patch v2 fixes some errors and warnings reported by checkpatch.pl. > =20 > This patch series also contain the 3 items: > 1. Add API to support setting TX rate for a queue or a VF. > 2. Implement the functionality of setting TX rate for queue or VF in IXGB= E PMD. > 3. Add commands in testpmd to test the functionality of setting TX rate f= or queue or VF. >=20 > Ouyang Changchun (3): > Add API to support set TX rate for a queue and VF. > Implement the functionality of setting TX rate for queue or VF in > IXGBE PMD. > Add commands in testpmd to test the functionality of setting TX rate > for queue or VF. >=20 > app/test-pmd/cmdline.c | 159 ++++++++++++++++++++++++++++++= +++++- > app/test-pmd/config.c | 47 +++++++++++ > app/test-pmd/testpmd.h | 3 + > lib/librte_ether/rte_ethdev.c | 71 ++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 51 ++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 122 +++++++++++++++++++++++++++ =20 > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 13 ++- > 7 files changed, 462 insertions(+), 4 deletions(-) >=20 This seems a bit backwards. queue rate limiting is rather a generic functi= on, that doesn't really need to know any details about the hardware, save f= or its maximum tx rate, but you're implementaiton requires that it be re-im= plemented for each PMD. Why not just export max tx rates from the PMD and = write a generic queuing libarary to do rate limitation for any PMD? Neil > -- > 1.9.0 >=20 >=20