From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
Date: Fri, 13 Jun 2014 01:54:42 +0000 [thread overview]
Message-ID: <F52918179C57134FAEC9EA62FA2F9625117E1E32@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20140612183250.106f8d87@nehalam.linuxnetplumber.net>
Acked by Changchun Ouyang
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
Sent: Friday, June 13, 2014 9:33 AM
To: Stephen Hemminger
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Signed-off-by: Stephen Hemminger <shemming@brocade.com>
--- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -0700
@@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et
ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET;
memcpy(ctrl.data, &nb_queues, sizeof(uint16_t));
- PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data);
-
dlen[0] = sizeof(uint16_t);
ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1);
next prev parent reply other threads:[~2014-06-13 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140612183045.19dfa1ef@nehalam.linuxnetplumber.net>
2014-06-13 1:32 ` Stephen Hemminger
2014-06-13 1:54 ` Ouyang, Changchun [this message]
2014-06-13 9:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F52918179C57134FAEC9EA62FA2F9625117E1E32@shsmsx102.ccr.corp.intel.com \
--to=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).