* [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
[not found] <20140612183045.19dfa1ef@nehalam.linuxnetplumber.net>
@ 2014-06-13 1:32 ` Stephen Hemminger
2014-06-13 1:54 ` Ouyang, Changchun
2014-06-13 9:23 ` Thomas Monjalon
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2014-06-13 1:32 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Signed-off-by: Stephen Hemminger <shemming@brocade.com>
--- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -0700
@@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et
ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET;
memcpy(ctrl.data, &nb_queues, sizeof(uint16_t));
- PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data);
-
dlen[0] = sizeof(uint16_t);
ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
2014-06-13 1:32 ` [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Stephen Hemminger
@ 2014-06-13 1:54 ` Ouyang, Changchun
2014-06-13 9:23 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Ouyang, Changchun @ 2014-06-13 1:54 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
Acked by Changchun Ouyang
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
Sent: Friday, June 13, 2014 9:33 AM
To: Stephen Hemminger
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Signed-off-by: Stephen Hemminger <shemming@brocade.com>
--- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -0700
@@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et
ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET;
memcpy(ctrl.data, &nb_queues, sizeof(uint16_t));
- PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data);
-
dlen[0] = sizeof(uint16_t);
ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled
2014-06-13 1:32 ` [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Stephen Hemminger
2014-06-13 1:54 ` Ouyang, Changchun
@ 2014-06-13 9:23 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-06-13 9:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2014-06-12 18:32, Stephen Hemminger:
> Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
> virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>
> Signed-off-by: Stephen Hemminger <shemming@brocade.com>
Acked-by: Changchun Ouyang <changchun.ouyang@intel.com>
Applied for version 1.7.0.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-13 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20140612183045.19dfa1ef@nehalam.linuxnetplumber.net>
2014-06-13 1:32 ` [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Stephen Hemminger
2014-06-13 1:54 ` Ouyang, Changchun
2014-06-13 9:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).