From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0371BAE99 for ; Fri, 13 Jun 2014 03:54:49 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 12 Jun 2014 18:55:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,468,1400050800"; d="scan'208";a="556635611" Received: from fmsmsx107.amr.corp.intel.com ([10.19.9.54]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2014 18:55:03 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.19.9.28) by FMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 12 Jun 2014 18:55:03 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by FMSMSX119.amr.corp.intel.com (10.19.9.28) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 12 Jun 2014 18:55:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.21]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.122]) with mapi id 14.03.0123.003; Fri, 13 Jun 2014 09:54:42 +0800 From: "Ouyang, Changchun" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Thread-Index: AQHPhqeHNILsxWqcPkOGxhuYcpkB+ptuRuOg Date: Fri, 13 Jun 2014 01:54:42 +0000 Message-ID: References: <20140612183045.19dfa1ef@nehalam.linuxnetplumber.net> <20140612183250.106f8d87@nehalam.linuxnetplumber.net> In-Reply-To: <20140612183250.106f8d87@nehalam.linuxnetplumber.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 01:54:50 -0000 Acked by Changchun Ouyang -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, June 13, 2014 9:33 AM To: Stephen Hemminger Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined. virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break = strict-aliasing rules [-Werror=3Dstrict-aliasing] Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -= 0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -= 0700 @@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et ctrl.hdr.cmd =3D VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET; memcpy(ctrl.data, &nb_queues, sizeof(uint16_t)); =20 - PMD_INIT_LOG(DEBUG, "ctrl.data=3D%d\n", *(int *)ctrl.data); - dlen[0] =3D sizeof(uint16_t); =20 ret =3D virtio_send_command(hw->cvq, &ctrl, dlen, 1);