From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 49DD5594D for ; Wed, 23 Jul 2014 03:05:49 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 22 Jul 2014 18:07:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,713,1400050800"; d="scan'208";a="573945203" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by fmsmga002.fm.intel.com with ESMTP; 22 Jul 2014 18:07:06 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 22 Jul 2014 18:07:05 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 22 Jul 2014 18:07:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.120]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.204]) with mapi id 14.03.0123.003; Wed, 23 Jul 2014 09:07:04 +0800 From: "Ouyang, Changchun" To: "Chen, Jing D" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop Thread-Index: AQHPpZKk8GiOSXQA8UaoJLkQJqG8O5us13yg Date: Wed, 23 Jul 2014 01:07:03 +0000 Message-ID: References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> <2633548.rrHgnQHcZ9@xps13> <4341B239C0EFF9468EE453F9E9F4604D015ADC4F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D015ADC4F@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 01:05:49 -0000 Yes, Mark(Jing Chen) has mentioned some reasons as below, Basically the comments/description for 2 fields(start_rx_per_q and start_tx= _per_q) is not clear, so we need add more. As for renaming, Mark has strong recommending to replace old one with new o= ne. Both Huawei and I agree with the new name, from my respective, both(old and= new one) are readable enough. =20 Thanks, Changchun -----Original Message----- From: Chen, Jing D=20 Sent: Tuesday, July 22, 2014 5:52 PM To: Thomas Monjalon; Ouyang, Changchun Cc: dev@dpdk.org Subject: RE: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start= /stop Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 22, 2014 5:38 PM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue=20 > start/stop >=20 > Hi, >=20 > 2014-07-22 15:47, Ouyang Changchun: > > This patch series include 3 things: > > 1) Rename the field name from start_rx_per_q to rx_enable_queue in=20 > > struct rte_eth_rxconf, and do same thing for TX. > > This patch also update description for field rx_enable_queue and > tx_enable_queue. > > 2) According to 1), update field name from start_rx_per_q to > rx_enable_queue in struct igb_rx_queue > > in ixgbe PMD, do same thing for TX. > > 3) Update its reference in sample vhost. >=20 > In order to be atomic (and do not break git bisect), you should submit=20 > it in one patch. > Title would be "ethdev: rename queue enabler field" or something like tha= t. > But the most important in such change is to explain why you make it. >=20 > Thanks > -- > Thomas The reason adding this patch is that "start_rx_per_q" and "start_tx_per_q" = has requirement in NIC driver in some cases. The implication includes: 1. don't fill mbuf address in RX ring in later dev start function call. 2. don't try to switch this rx/tx queues on in later dev start function cal= l. Instead, application will call rte_eth_dev_rx/tx_queue_start/stop to co= ntrol this queue. If the NIC driver tried to support these 2 options, it will have to satisfy= above 2 conditions. But the problem is that the 2 fields definition don't = have a word to claim on their requirement. So, we needs this patch and add = comments.=20 As for renaming, it's not so important. Just for better understanding.=20 =20