From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B86CE959 for ; Mon, 28 Jul 2014 06:32:43 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 27 Jul 2014 21:28:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,746,1400050800"; d="scan'208";a="579853533" Received: from fmsmsx108.amr.corp.intel.com ([10.19.9.228]) by orsmga002.jf.intel.com with ESMTP; 27 Jul 2014 21:34:26 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.19.9.28) by FMSMSX108.amr.corp.intel.com (10.19.9.228) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 27 Jul 2014 21:34:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.19.9.28) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 27 Jul 2014 21:34:25 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.120]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.112]) with mapi id 14.03.0123.003; Mon, 28 Jul 2014 12:34:23 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop Thread-Index: AQHPpZCvhu+LK8yu0Umk12KtxQKIiZu07sZQ Date: Mon, 28 Jul 2014 04:34:23 +0000 Message-ID: References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> <2633548.rrHgnQHcZ9@xps13> In-Reply-To: <2633548.rrHgnQHcZ9@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2014 04:32:44 -0000 Hi Thomas, I have generated patch v2 to resolve this according to your comments. Pls see attachment. Thanks and regards, Changchun -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Tuesday, July 22, 2014 5:38 PM To: Ouyang, Changchun Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start= /stop Hi, 2014-07-22 15:47, Ouyang Changchun: > This patch series include 3 things: > 1) Rename the field name from start_rx_per_q to rx_enable_queue in=20 > struct rte_eth_rxconf, and do same thing for TX. > This patch also update description for field rx_enable_queue and tx_enabl= e_queue. > 2) According to 1), update field name from start_rx_per_q to=20 > rx_enable_queue in struct igb_rx_queue in ixgbe PMD, do same thing for T= X. > 3) Update its reference in sample vhost. In order to be atomic (and do not break git bisect), you should submit it i= n one patch. Title would be "ethdev: rename queue enabler field" or something like that. But the most important in such change is to explain why you make it. Thanks -- Thomas