From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <changchun.ouyang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by dpdk.org (Postfix) with ESMTP id EB893959
 for <dev@dpdk.org>; Mon, 28 Jul 2014 09:34:11 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
 by azsmga101.ch.intel.com with ESMTP; 28 Jul 2014 00:35:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,747,1400050800"; d="scan'208";a="462169129"
Received: from fmsmsx107.amr.corp.intel.com ([10.19.9.54])
 by azsmga001.ch.intel.com with ESMTP; 28 Jul 2014 00:35:54 -0700
Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by
 FMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server (TLS) id
 14.3.123.3; Mon, 28 Jul 2014 00:35:54 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Mon, 28 Jul 2014 00:35:54 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.120]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.112]) with mapi id 14.03.0123.003;
 Mon, 28 Jul 2014 15:35:51 +0800
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] virtio: Fix 2 compilation issues in virtio PMD
Thread-Index: AQHPpvvkaUs8bQWJF0+qw9/27Grq/pu1HkTA
Date: Mon, 28 Jul 2014 07:35:52 +0000
Message-ID: <F52918179C57134FAEC9EA62FA2F96251180B281@shsmsx102.ccr.corp.intel.com>
References: <1406177865-9964-1-git-send-email-changchun.ouyang@intel.com>
In-Reply-To: <1406177865-9964-1-git-send-email-changchun.ouyang@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] virtio: Fix 2 compilation issues in virtio
	PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jul 2014 07:34:12 -0000

Hi all,

> -----Original Message-----
> From: Ouyang, Changchun
> Sent: Thursday, July 24, 2014 12:58 PM
> To: dev@dpdk.org
> Cc: Cao, Waterman; Ouyang, Changchun
> Subject: [PATCH] virtio: Fix 2 compilation issues in virtio PMD
>=20
> Fix 2 compilation issues in virtio PMD when dump option is enabled.
>=20
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
>  lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
>  lib/librte_pmd_virtio/virtqueue.h     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>=20

The offending commit which cause these 2 issues are:

commit f37cdfde46a30d93f3dd8a4e01243be8bc0ac142
Author: Stephen Hemminger <stephen@networkplumber.org>=09
Date:   Fri Jun 13 18:06:23 2014 -0700
=20
    virtio: remove unused virtqueue name
   =20
    vq_name is only used when setting up queue, and does not need
    to be saved.


commit ce65e697c67ba1a357d806eed05957b3d43f562c
Author: Stephen Hemminger <stephen@networkplumber.org>
Date:   Fri Jun 13 18:06:25 2014 -0700
=20
    virtio: simplify the hardware structure
   =20
    The host_features are never used after negotiation.
    The PCI information is unused (and available in rte_pci if needed).

Thanks
Changchun