From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8767D7E6A for ; Mon, 13 Oct 2014 09:41:02 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 13 Oct 2014 00:48:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,708,1406617200"; d="scan'208";a="617571476" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 13 Oct 2014 00:48:06 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Oct 2014 00:48:05 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Oct 2014 00:48:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.203]) with mapi id 14.03.0195.001; Mon, 13 Oct 2014 15:48:03 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH] vhost: Fix the vhost broken issue Thread-Index: AQHP5rjhrquA8OtN5U2rZj68b+57FZwtpKMg Date: Mon, 13 Oct 2014 07:48:03 +0000 Message-ID: References: <1413185980-17348-1-git-send-email-changchun.ouyang@intel.com> In-Reply-To: <1413185980-17348-1-git-send-email-changchun.ouyang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: Fix the vhost broken issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 07:41:03 -0000 Hi Thomas, If HuaweiXie's patch set for vhost library and new vhost sample could be ap= plied into dpdk.org very soon, Then this patch could be depressed/superseded, I think his patch can fix th= is issue. Otherwise, this patch could be high priority as the vhost is broken in the = tip code due to recent commit related to mbuf change. Thanks and regards,=20 Changchun > -----Original Message----- > From: Ouyang, Changchun > Sent: Monday, October 13, 2014 3:40 PM > To: dev@dpdk.org > Cc: Cao, Waterman; Ouyang, Changchun > Subject: [PATCH] vhost: Fix the vhost broken issue >=20 > As the vhost sample is broken by the following commit, > commit 08b563ffb19d8baf59dd84200f25bc85031d18a7 > Author: Olivier Matz > Date: Thu Sep 11 14:15:35 2014 +0100 > mbuf: replace data pointer by an offset >=20 > It leads to segment fault error in vhost when binding a virtio device MAC > address to its corresponding VMDq pool by executing command line 'start t= x- > first' in test-pmd on guest. >=20 > This patch fixes that issue. >=20 > Signed-off-by: Changchun Ouyang > --- > examples/vhost/main.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index > 9cf8e20..a6db607 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -1782,6 +1782,7 @@ virtio_dev_tx(struct virtio_net* dev, struct > rte_mempool *mbuf_pool) > /* Setup dummy mbuf. This is copied to a real mbuf if > transmitted out the physical port. */ > m.data_len =3D desc->len; > m.pkt_len =3D desc->len; > + m.buf_addr =3D (void *)(uintptr_t)buff_addr; > m.data_off =3D 0; >=20 > PRINT_PACKET(dev, (uintptr_t)buff_addr, desc->len, 0); > -- > 1.8.4.2